From: Johannes Berg <johannes@sipsolutions.net>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: <linux-wireless@vger.kernel.org>,
Reinette Chatre <reinette.chatre@intel.com>
Subject: Re: [RFC PATCH 1/2] mac80211: add interface for disabling QoS
Date: Fri, 19 Mar 2010 17:39:25 +0100 [thread overview]
Message-ID: <b0ff25b67318cca987ea1b244b33ccf0@localhost> (raw)
In-Reply-To: <20100319155749.GA4972@dhcp-lab-161.englab.brq.redhat.com>
On Fri, 19 Mar 2010 16:57:50 +0100, Stanislaw Gruszka
<sgruszka@redhat.com>
wrote:
> On Fri, Mar 19, 2010 at 07:37:29AM -0700, Johannes Berg wrote:
>> On Fri, 2010-03-19 at 11:56 +0100, Stanislaw Gruszka wrote:
>> > Add BSS_CHANGE_QOS_DISABLED flag to pass to drivers when want to
>> > disable
>> > QoS (aka WMM, WME).
>>
>> Umm? Take another look at how the change flags etc. work
>
> You want it that way:
> changed |= BSS_CHANGED_QOS
> sdata->vif.bss_conf.qos_disabled = true;
> ?
Yes.
johannes
next prev parent reply other threads:[~2010-03-19 16:39 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-09 13:21 [RFC] mac80211,iwlwifi: disabling qos queues Stanislaw Gruszka
2010-03-10 15:20 ` Stanislaw Gruszka
2010-03-10 23:59 ` Johannes Berg
2010-03-11 9:56 ` Stanislaw Gruszka
2010-03-11 15:06 ` Johannes Berg
2010-03-16 14:51 ` Stanislaw Gruszka
2010-03-16 21:18 ` Johannes Berg
2010-03-17 9:26 ` Stanislaw Gruszka
2010-03-17 15:51 ` Johannes Berg
2010-03-19 10:56 ` [RFC PATCH 1/2] mac80211: add interface for disabling QoS Stanislaw Gruszka
2010-03-19 10:59 ` [RFC PATCH 2/2] iwlwifi: implement " Stanislaw Gruszka
2010-03-19 14:37 ` [RFC PATCH 1/2] mac80211: add interface for " Johannes Berg
2010-03-19 15:57 ` Stanislaw Gruszka
2010-03-19 16:39 ` Johannes Berg [this message]
2010-03-10 15:21 ` [RFC PATCH 1/2] mac80211: disable_qos callback Stanislaw Gruszka
2010-03-10 20:31 ` Luis R. Rodriguez
2010-03-11 9:33 ` Stanislaw Gruszka
2010-03-17 9:19 ` Stanislaw Gruszka
2010-03-10 15:22 ` [RFC PATCH 2/2] iwlwifi: implement disable_qos Stanislaw Gruszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0ff25b67318cca987ea1b244b33ccf0@localhost \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=reinette.chatre@intel.com \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).