From: Johannes Berg <johannes@sipsolutions.net>
To: Priyansha Tiwari <priyansha.tiwari@oss.qualcomm.com>
Cc: veerendranath.jakkam@oss.qualcomm.com,
linux-wireless@vger.kernel.org, quic_drohan@quicinc.com
Subject: Re: [PATCH wireless-next v5 3/4] wifi: mac80211: implement STA-mode peer probing
Date: Mon, 06 Jul 2026 12:53:58 +0200 [thread overview]
Message-ID: <b1d6bff2709e5368b635b956b435cccf4606cb66.camel@sipsolutions.net> (raw)
In-Reply-To: <20260611062225.2144241-4-pritiwa@qti.qualcomm.com>
On Thu, 2026-06-11 at 11:52 +0530, Priyansha Tiwari wrote:
>
> @@ -1396,7 +1396,7 @@ struct ieee80211_tx_info {
> u8 pad;
> u16 tx_time;
> u8 flags;
> - u8 pad2;
> + u8 link_valid:1, link_id:4;
[...]
> info->control.flags |= u32_encode_bits(link_id,
> IEEE80211_TX_CTRL_MLO_LINK);
> + if (link_id != IEEE80211_LINK_UNSPECIFIED) {
> + info->status.link_valid = 1;
> + info->status.link_id = link_id;
> + }
These changes seem so *obviously* wrong that I can't believe you're
actually trying to achieve what it looks like.
I guess I'll apply patches 1 and 2.
johannes
next prev parent reply other threads:[~2026-07-06 10:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-11 6:22 [PATCH wireless-next v5 0/4] wifi: nl80211: introduce PROBE_PEER for AP and STA Priyansha Tiwari
2026-06-11 6:22 ` [PATCH wireless-next v5 1/4] wifi: nl80211/cfg80211: rename probe_client to probe_peer Priyansha Tiwari
2026-06-11 6:22 ` [PATCH wireless-next v5 2/4] wifi: cfg80211/nl80211: add STA-mode peer probing Priyansha Tiwari
2026-06-11 6:22 ` [PATCH wireless-next v5 3/4] wifi: mac80211: implement " Priyansha Tiwari
2026-07-06 10:53 ` Johannes Berg [this message]
2026-07-06 10:54 ` Johannes Berg
2026-06-11 6:22 ` [PATCH wireless-next v5 4/4] wifi: mac80211_hwsim: report TX status link_id Priyansha Tiwari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b1d6bff2709e5368b635b956b435cccf4606cb66.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=priyansha.tiwari@oss.qualcomm.com \
--cc=quic_drohan@quicinc.com \
--cc=veerendranath.jakkam@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox