From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E7ADC4332F for ; Mon, 13 Nov 2023 16:11:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230284AbjKMQLM (ORCPT ); Mon, 13 Nov 2023 11:11:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48128 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230034AbjKMQLL (ORCPT ); Mon, 13 Nov 2023 11:11:11 -0500 Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.183]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B14310E0 for ; Mon, 13 Nov 2023 08:11:05 -0800 (PST) X-Virus-Scanned: Proofpoint Essentials engine Received: from mail3.candelatech.com (mail2.candelatech.com [208.74.158.173]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 78D5C9C0061; Mon, 13 Nov 2023 16:11:01 +0000 (UTC) Received: from [192.168.1.115] (unknown [98.97.112.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail3.candelatech.com (Postfix) with ESMTPSA id 4A04013C2B0; Mon, 13 Nov 2023 08:10:51 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 mail3.candelatech.com 4A04013C2B0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=candelatech.com; s=default; t=1699891858; bh=C7CapxtBMMZZdzsCXVqlwHkDLQnyVPV1jyGOMx+Q46Y=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=H3z8GcPdWIVHyGUfnp50D7zIQoJbL1tKvU0vfGHdJnpX5Ygk4IwIOOFaBQurgxRYi MPw+Y3bsiiHI+WEkuvUr9GWyf+mqWLea+oOE/VaepkQ4jwvGyCzhMDtfGQb2Om8jmL RtY+HYT6kCLTS1VhyXElDola79NFdAW+LmkpyqwU= Subject: Re: [PATCH v4] wifi: iwlwifi: fix system commands group ordering To: Emmanuel Grumbach , Linus Torvalds Cc: Kalle Valo , Johannes Berg , Miri Korenblit , Gregory Greenman , Emmanuel Grumbach , Linux Wireless , pagadala.yesu.anjaneyulu@intel.com, Linux Regressions , Bagas Sanjaya , =?UTF-8?B?TmlrbMSBdnMgS2/EvGVzxYZpa292cw==?= , Damian Tometzki References: <20231112095943.19353-1-emmanuel.grumbach@intel.com> <20231112143620.36619-1-emmanuel.grumbach@intel.com> <875y26ajks.fsf@kernel.org> From: Ben Greear Organization: Candela Technologies Message-ID: Date: Mon, 13 Nov 2023 08:10:50 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-MW Content-Transfer-Encoding: 8bit X-MDID: 1699891863-BrwEj1L2TOuR X-MDID-O: us5;at1;1699891863;BrwEj1L2TOuR;;3dd19b123b29985d5fd746a2b0eecbd6 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 11/12/23 11:53 AM, Emmanuel Grumbach wrote: > On Sun, Nov 12, 2023 at 9:39 PM Linus Torvalds > wrote: >> >> On Sun, 12 Nov 2023 at 10:54, Kalle Valo wrote: >>> >>> Linus, I suspect it will take a while before we make a new wireless pull >>> request (there's currently just one commit in the wireless tree). So if >>> you want to take this directly to your tree please go ahead, otherwise >>> you get it via the normal route in a week or two. Just let us know what >>> you prefer. >>> >>> Acked-by: Kalle Valo >> >> Ok, I just tested it in my private tree, and it fixes the WARN_ON() as >> expected, so I'll apply it for real. > > Good to know - thanks. > >> >> However, now that I don't have that big warning in there, I do note >> another iwlwifi issue that is new to this meger window: >> >> debugfs: Directory 'iwlmvm' with parent 'netdev:wlo2' already present! >> iwlwifi 0000:45:00.0: Failed to create debugfs directory under netdev:wlo2 >> debugfs: Directory 'iwlmvm' with parent 'netdev:wlo2' already present! >> iwlwifi 0000:45:00.0: Failed to create debugfs directory under netdev:wlo2 >> >> and looking at my system logs, this is new. >> >> It looks like it is probably due to >> >> c36235acb34f ("wifi: iwlwifi: mvm: rework debugfs handling") >> e9dd25550770 ("wifi: iwlwifi: mvm: add a per-link debugfs") >> >> but that's just from looking at the patches (ie no bisection or any >> real effort). > > Don't bother, we'll take a look. > >> >> This is after the system has come up, so I assume it's when >> networkmanager or whatever actually is setting that wireless thing up. > > Most likely the network-manager brings the device up several times or something > like that, but let's not blame them before we check what happens internally. The debugfs warnings are seen all of my systems, no network manager for me, but I am bringing stations up and down a lot. Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com