From: Ping-Ke Shih <pkshih@realtek.com>
To: Bitterblue Smith <rtl8821cerfe2@gmail.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Stefan Lippers-Hollmann <s.l-h@gmx.de>,
Christian Hewitt <chewitt@libreelec.tv>
Subject: RE: [PATCH v6 03/11] wifi: rtlwifi: Add rtl8192du/hw.{c,h}
Date: Tue, 21 May 2024 02:18:51 +0000 [thread overview]
Message-ID: <b21b15b482e54d359bde965df3f33e45@realtek.com> (raw)
In-Reply-To: <44fe73c4-a852-4de8-8f3a-081749ac5709@gmail.com>
Bitterblue Smith <rtl8821cerfe2@gmail.com> wrote:
> These contain mostly hardware init/deinit routines for RTL8192DU.
>
> Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>
> ---
> v6:
> - Don't call local_irq_enable in rtl92du_hw_init. It seems to be
> pointless.
> - Update copyright year.
> - Remove some unused includes.
> - Make all functions use the prefix "rtl92du".
Something like rtl92de_stop_tx_beacon() called by this file should be
prefix "rtl92d" because they are shared with 8192DU and 8192DE.
I missed this point while moving 8192de code to common part.
I think we should add a patch as first one patch to change the naming.
next prev parent reply other threads:[~2024-05-21 2:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-17 21:13 [PATCH v6 00/11] wifi: rtlwifi: Add new rtl8192du driver Bitterblue Smith
2024-05-17 21:14 ` [PATCH v6 01/11] wifi: rtlwifi: Add rtl8192du/table.{c,h} Bitterblue Smith
2024-05-17 21:15 ` [PATCH v6 02/11] wifi: rtlwifi: Add new members to struct rtl_priv for RTL8192DU Bitterblue Smith
2024-05-17 21:16 ` [PATCH v6 03/11] wifi: rtlwifi: Add rtl8192du/hw.{c,h} Bitterblue Smith
2024-05-21 2:18 ` Ping-Ke Shih [this message]
2024-05-17 21:16 ` [PATCH v6 04/11] wifi: rtlwifi: Add rtl8192du/phy.{c,h} Bitterblue Smith
2024-05-21 2:28 ` Ping-Ke Shih
2024-05-17 21:17 ` [PATCH v6 05/11] wifi: rtlwifi: Add rtl8192du/trx.{c,h} Bitterblue Smith
2024-05-17 21:17 ` [PATCH v6 06/11] wifi: rtlwifi: Add rtl8192du/rf.{c,h} Bitterblue Smith
2024-05-17 21:18 ` [PATCH v6 07/11] wifi: rtlwifi: Add rtl8192du/fw.{c,h} and rtl8192du/led.{c,h} Bitterblue Smith
2024-05-17 21:18 ` [PATCH v6 08/11] wifi: rtlwifi: Add rtl8192du/dm.{c,h} Bitterblue Smith
2024-05-17 21:19 ` [PATCH v6 09/11] wifi: rtlwifi: Constify rtl_hal_cfg.{ops,usb_interface_cfg} and rtl_priv.cfg Bitterblue Smith
2024-05-17 21:19 ` [PATCH v6 10/11] wifi: rtlwifi: Add rtl8192du/sw.c Bitterblue Smith
2024-05-17 21:20 ` [PATCH v6 11/11] wifi: rtlwifi: Enable the new rtl8192du driver Bitterblue Smith
2024-05-18 4:44 ` [PATCH v6 00/11] wifi: rtlwifi: Add " Stefan Lippers-Hollmann
2024-05-21 2:49 ` Ping-Ke Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b21b15b482e54d359bde965df3f33e45@realtek.com \
--to=pkshih@realtek.com \
--cc=Larry.Finger@lwfinger.net \
--cc=chewitt@libreelec.tv \
--cc=linux-wireless@vger.kernel.org \
--cc=rtl8821cerfe2@gmail.com \
--cc=s.l-h@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).