From: "Arnd Bergmann" <arnd@arndb.de>
To: "Johannes Berg" <johannes@sipsolutions.net>,
"Arnd Bergmann" <arnd@kernel.org>,
"Gregory Greenman" <gregory.greenman@intel.com>,
"Kalle Valo" <kvalo@kernel.org>,
"Luca Coelho" <luciano.coelho@intel.com>,
"Shahar S Matityahu" <shahar.s.matityahu@intel.com>
Cc: "Mukesh Sisodiya" <mukesh.sisodiya@intel.com>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iwlwifi: dbg_ini: fix structure packing
Date: Mon, 14 Aug 2023 23:02:19 +0200 [thread overview]
Message-ID: <b29731ef-0a72-402c-846a-b37d86712641@app.fastmail.com> (raw)
In-Reply-To: <9a6b2c18b599e5c2e7cea99fec84a4ecb5092da5.camel@sipsolutions.net>
On Mon, Aug 14, 2023, at 20:28, Johannes Berg wrote:
> On Fri, 2023-06-16 at 11:03 +0200, Arnd Bergmann wrote:
>>
>> As the original intention was apparently to make the entire structure
>> unaligned, mark the innermost members the same way so the union
>> becomes packed as well.
>
> Hm. Not sure exactly what you mean by that, but shouldn't we make that
> "union { ... } __packed"?
Up to you, the effect is the same, as the other two members are already
packed. I generally try to keep the packing to the members that are
actually unaligned, to make the code more efficient, but in this case
the entire structure is unaligned, so it doesn't matter.
Arnd
next prev parent reply other threads:[~2023-08-14 21:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-16 9:03 [PATCH] iwlwifi: dbg_ini: fix structure packing Arnd Bergmann
2023-08-14 18:28 ` Johannes Berg
2023-08-14 21:02 ` Arnd Bergmann [this message]
2023-08-28 12:46 ` Greenman, Gregory
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b29731ef-0a72-402c-846a-b37d86712641@app.fastmail.com \
--to=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=gregory.greenman@intel.com \
--cc=johannes@sipsolutions.net \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luciano.coelho@intel.com \
--cc=mukesh.sisodiya@intel.com \
--cc=shahar.s.matityahu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox