From: Larry Finger <Larry.Finger@lwfinger.net>
To: Bharat Kumar Gogada <bharat.kumar.gogada@xilinx.com>,
chaoming_li@realsil.com.cn, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: kvalo@codeaurora.org, netdev@vger.kernel.org, rgummal@xilinx.com,
Bharat Kumar Gogada <bharatku@xilinx.com>
Subject: Re: [PATCH] rtlwifi: rtl8192x: Enabling and disabling hardware interrupts after enabling local irq flags
Date: Thu, 19 Jan 2017 20:41:27 -0600 [thread overview]
Message-ID: <b2e783f6-fa09-e287-8119-266299cdae22@lwfinger.net> (raw)
In-Reply-To: <1484820854-16719-1-git-send-email-bharatku@xilinx.com>
On 01/19/2017 04:14 AM, Bharat Kumar Gogada wrote:
> -Realtek 8192CE chipset maintains local irq flags after enabling/disabling
> hardware interrupts.
> -Hardware interrupts are enabled before enabling the local irq
> flags(these flags are being checked in interrupt handler),
> leading to race condition on some RP, where the irq line between
> bridge and GIC goes high at ASSERT_INTx and goes low only
> at DEASSERT_INTx. In this kind of RP by the time ASSERT_INTx is seen
> irq_enable flag is still set to false, resulting in continuous
> interrupts seen by CPU as DEASSERT_INTx cannot be sent since
> flag is still false and making CPU stall.
> -Changing the sequence of setting these irq flags.
>
> Signed-off-by: Bharat Kumar Gogada <bharatku@xilinx.com>
> ---
This patch should be enhanced with the smb_xx() calls as suggested by by Lino.
The subject should be changed. I would suggest something like "rtlwifi:
rtl8192ce: Prevent race condition when enabling interrupts", as it explains the
condition you are preventing.
The other PCI drivers also have the same problem. Do you want to prepare the
patches, or should I do it?
Larry
next prev parent reply other threads:[~2017-01-20 2:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-19 10:14 [PATCH] rtlwifi: rtl8192x: Enabling and disabling hardware interrupts after enabling local irq flags Bharat Kumar Gogada
2017-01-19 14:35 ` Lino Sanfilippo
2017-01-19 18:08 ` Larry Finger
2017-01-19 22:13 ` Lino Sanfilippo
2017-01-20 2:41 ` Larry Finger [this message]
2017-01-20 11:14 ` Lino Sanfilippo
2017-01-20 14:14 ` Bharat Kumar Gogada
2017-01-20 16:30 ` Larry Finger
2017-01-24 10:03 ` Bharat Kumar Gogada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2e783f6-fa09-e287-8119-266299cdae22@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=bharat.kumar.gogada@xilinx.com \
--cc=bharatku@xilinx.com \
--cc=chaoming_li@realsil.com.cn \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rgummal@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox