From: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
To: Tristan Madani <tristmd@gmail.com>,
Christian Lamparter <chunkeey@googlemail.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
Tristan Madani <tristan@talencesecurity.com>
Subject: Re: [PATCH v3 0/3] wifi: carl9170: firmware trust boundary hardening
Date: Wed, 1 Jul 2026 10:47:51 -0700 [thread overview]
Message-ID: <b31525d8-e3b7-4ff9-bee6-4974fa9f9a6a@oss.qualcomm.com> (raw)
In-Reply-To: <20260421134929.325662-1-tristmd@gmail.com>
On 4/21/2026 6:49 AM, Tristan Madani wrote:
> From: Tristan Madani <tristan@talencesecurity.com>
>
> This series adds missing bounds checks for firmware-controlled fields
> in the carl9170 USB driver.
>
> Patch 1 bounds the cmd callback memcpy to prevent heap overflow from
> an oversized firmware response. Patch 2 fixes an off-by-two in the TX
> status handler. Patch 3 caps the failover copy to rx_failover_missing
> bytes, using min_t per Christian Lamparter.
>
> Changes in v3:
> - Regenerated from wireless-next with proper git format-patch.
>
> Changes in v2:
> - Use min_t() instead of separate if-check in patch 3, per
> Christian Lamparter.
>
> Tristan Madani (3):
> wifi: carl9170: bound memcpy length in cmd callback to prevent OOB
> read
> wifi: carl9170: fix OOB read from off-by-two in TX status handler
> wifi: carl9170: fix buffer overflow in rx_stream failover path
>
> drivers/net/wireless/ath/carl9170/rx.c | 7 +++++--
> drivers/net/wireless/ath/carl9170/tx.c | 2 +-
> 2 files changed, 6 insertions(+), 3 deletions(-)
>
Christian, will you be able to review this series?
I'll take it once I get reviewed-by or acked-by tags.
And then we can ignore the dups from others.
/jeff
next prev parent reply other threads:[~2026-07-01 17:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-21 13:49 [PATCH v3 0/3] wifi: carl9170: firmware trust boundary hardening Tristan Madani
2026-04-21 13:49 ` [PATCH v3 1/3] wifi: carl9170: bound memcpy length in cmd callback to prevent OOB read Tristan Madani
2026-07-04 19:48 ` Christian Lamparter
2026-04-21 13:49 ` [PATCH v3 2/3] wifi: carl9170: fix OOB read from off-by-two in TX status handler Tristan Madani
2026-07-04 19:48 ` Christian Lamparter
2026-04-21 13:49 ` [PATCH v3 3/3] wifi: carl9170: fix buffer overflow in rx_stream failover path Tristan Madani
2026-07-01 18:32 ` Jeff Johnson
2026-07-04 19:48 ` Christian Lamparter
2026-07-01 17:47 ` Jeff Johnson [this message]
2026-07-04 19:47 ` [PATCH v3 0/3] wifi: carl9170: firmware trust boundary hardening Christian Lamparter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b31525d8-e3b7-4ff9-bee6-4974fa9f9a6a@oss.qualcomm.com \
--to=jeff.johnson@oss.qualcomm.com \
--cc=chunkeey@googlemail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=tristan@talencesecurity.com \
--cc=tristmd@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox