Linux wireless drivers development
 help / color / mirror / Atom feed
From: Arend Van Spriel <arend.vanspriel@broadcom.com>
To: "Rafał Miłecki" <zajec5@gmail.com>, "Kalle Valo" <kvalo@codeaurora.org>
Cc: linux-wireless@vger.kernel.org,
	brcm80211-dev-list.pdl@broadcom.com,
	brcm80211-dev-list@cypress.com,
	"Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH 4/4] brcmfmac: reset PCIe bus on a firmware crash
Date: Wed, 6 Mar 2019 10:08:52 +0100	[thread overview]
Message-ID: <b33340cc-20ac-9bae-7735-1849dab06a27@broadcom.com> (raw)
In-Reply-To: <20190226131119.7907-5-zajec5@gmail.com>



On 2/26/2019 2:11 PM, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> This includes bus reset & reloading a firmware. It should be sufficient
> for a user space to (setup and) use a wireless device again.
> 
> Support for reset on USB & SDIO can be added later.

It should be noted that you end up with a new wiphy instance though. We 
could try to avoid that in subsequent change.

Reviewed-by: Arend van Spriel <arend.vanspriel@broadcom.com>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
>   .../broadcom/brcm80211/brcmfmac/bus.h         | 10 ++++++
>   .../broadcom/brcm80211/brcmfmac/core.c        | 12 +++++++
>   .../broadcom/brcm80211/brcmfmac/core.h        |  2 ++
>   .../broadcom/brcm80211/brcmfmac/pcie.c        | 35 +++++++++++++++++++
>   4 files changed, 59 insertions(+)

      reply	other threads:[~2019-03-06  9:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-26 13:11 [PATCH 0/4] brcmfmac: recover PCIe devices from firmware crashes Rafał Miłecki
2019-02-26 13:11 ` [PATCH 1/4] brcmfmac: support repeated brcmf_fw_alloc_request() calls Rafał Miłecki
2019-03-06  8:49   ` Arend Van Spriel
2019-04-04 10:00   ` Kalle Valo
2019-02-26 13:11 ` [PATCH 2/4] brcmfmac: get RAM info right before downloading PCIe firmware Rafał Miłecki
2019-03-06  8:59   ` Arend Van Spriel
2019-02-26 13:11 ` [PATCH 3/4] brcmfmac: add a function designated for handling firmware fails Rafał Miłecki
2019-03-06  9:02   ` Arend Van Spriel
2019-02-26 13:11 ` [PATCH 4/4] brcmfmac: reset PCIe bus on a firmware crash Rafał Miłecki
2019-03-06  9:08   ` Arend Van Spriel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b33340cc-20ac-9bae-7735-1849dab06a27@broadcom.com \
    --to=arend.vanspriel@broadcom.com \
    --cc=brcm80211-dev-list.pdl@broadcom.com \
    --cc=brcm80211-dev-list@cypress.com \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=rafal@milecki.pl \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox