From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23AEDC77B7D for ; Mon, 15 May 2023 13:10:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241551AbjEONKm (ORCPT ); Mon, 15 May 2023 09:10:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57084 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242236AbjEONKY (ORCPT ); Mon, 15 May 2023 09:10:24 -0400 Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 481E9269F; Mon, 15 May 2023 06:10:02 -0700 (PDT) Received: by mail-pl1-x635.google.com with SMTP id d9443c01a7336-1ab032d9266so117773155ad.0; Mon, 15 May 2023 06:10:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684156201; x=1686748201; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/pd7IH8iQ4KOAD+IGRJ2kpU4wAM/iguRWIx6a9cMo2M=; b=G4iss71zL/pAgQitGB/tMRoEosPEK6miLaIAsf+UOJ6GJwmgzEft4m29hABqk+l8nb F0V9nt4vcBsaCor6syjSCxACXETUI54Gx4QF5Au3YbYNbI9JcxejZEaFYYLpGkLVajIT Yq95TK1jpDTkoSp0xtSBIsHS4orOrXPKMfOsaSQNEYRoOqkjBmLuwwbOPPGM6S144M8I PqqTnHX6MAH7SKOS+JWuVZh30B7tBQutM/SSCblobe1HMnhLiQRXWbfI8N80RwfD15Ua U3k+05Xza9Dp3M+hlyyFsXF7pln+SC+Qr7Pizzd/EhUl285lvsKilqeWZwnMsndW0M6f Y8Ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684156201; x=1686748201; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/pd7IH8iQ4KOAD+IGRJ2kpU4wAM/iguRWIx6a9cMo2M=; b=HheP3V51CiVUDKvnBq7PpUDgNqh00EZTHQlxvdwsTDhBld5bujc8C4f3f3wrpgeaA/ 4NGVmi7ff4spt0ncC6K4oKybek2Jur6beUNTZqPzPFF5lSem9xcaAcLBUtBVx0PCzP0Z lKOh0CFMon46tqPiBFp6sMjhO5cCuXga5WmYjPV8S02Xdw2dxRhe+YVgqEbzyzilmNCX lNU2ksywGYMMcJ4txMQu5t41Mhj5pefYYYUlKF2/Vn+xg1sc6/IWGGywfoS3UWtIY3Ck 9Chib3rlTKIa/SUay2XmAvso9YyM4JLoRKLf5y/Jl2nguafzaHJKaTAL2wsLbjt+jupO sQlQ== X-Gm-Message-State: AC+VfDw7ivLGy9xcckBOXpJzGn3ILYi4e3AdSraocROK7yDhuW00aBoU wtfOudgwo8j3/2yIEvJMYcA= X-Google-Smtp-Source: ACHHUZ6tAg9ha1mMvaWILouNIGS4l8+m+gtn+R6sNaWAfRPEal9tyuaSig5YDstqPJlQfVeWhCPh7A== X-Received: by 2002:a17:902:d2c2:b0:1ac:5dfa:3545 with SMTP id n2-20020a170902d2c200b001ac5dfa3545mr36716635plc.68.1684156200448; Mon, 15 May 2023 06:10:00 -0700 (PDT) Received: from [192.168.43.80] (subs03-180-214-233-3.three.co.id. [180.214.233.3]) by smtp.gmail.com with ESMTPSA id m9-20020a170902db0900b001a6a53c3b04sm13519333plx.306.2023.05.15.06.09.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 May 2023 06:09:59 -0700 (PDT) Message-ID: Date: Mon, 15 May 2023 20:09:49 +0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: Fwd: Freeze after resuming from hibernation (culprit is brcmfmac change?) To: Hans de Goede , Linux Regressions , Linux Kernel Mailing List , Linux Wireless , Broadcom 80211 Devices , SHA cyfmac Subsystem , Linux Kernel Network Developers Cc: Hante Meuleman , Pieter-Paul Giesberts , Franky Lin , Arend van Spriel , Kalle Valo , julien.falque@gmail.com References: <018f62d0-ee1d-9198-9c38-e45b10921e2e@gmail.com> Content-Language: en-US From: Bagas Sanjaya In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 5/15/23 15:56, Hans de Goede wrote: > Hi, > > On 5/15/23 04:21, Bagas Sanjaya wrote: >> Hi, >> >> I notice a regression report on bugzilla [1]. Quoting from it: >> >>> julien.falque@gmail.com 2023-05-14 09:55:38 UTC >>> >>> Since a Kernel update a few weeks ago, my laptop freezes when resuming from hibernation. It seems to handle the resume process normally but at the moment I should see Gnome login screen, I either get a black screen with just a white underscore instead, or nothing displayed at all (no backlight). I can't do anything at that point and I have to hard reboot. >>> >>> Steps to reproduce: >>> - hibernate >>> - resume >>> - wait until the resuming process should finish: black screen instead of e.g. Gnome's login screen >>> >>> journalctl gives nothing between the beginning of the resume and the crash, as if it never happened. >>> >>> I have a Dell XPS 15 (9550) with Arch Linux. The issue happens on linux (since v6.2.0 I think) but linux-lts (currently v6.1.28) is fine. >>> >>> A bisect on linux-git gave commit da6d9c8ecd00 as the cause of the problem. >> >> See bugzilla for the full thread. >> >> Julien: I asked you to also provide dmesg log as I don't know >> what exactly happened, but you mentioned the culprit was >> da6d9c8ecd00e2 ("wifi: brcmfmac: add firmware vendor info in driver info"), >> which implies that the crash involves your wifi device. From my experience >> though, GDM crashes are usually caused by xwayland. >> >> Anyway, I'm adding this to regzbot: >> >> #regzbot introduced: da6d9c8ecd00e2 https://bugzilla.kernel.org/show_bug.cgi?id=217442 >> #regzbot title: brcmfmac firmware vendor info addition triggers GDM crash on resuming from hibernation > > da6d9c8ecd00e2 is known to cause a NULL pointer deref on resume, > which is likely what is happening here. This is fixed by: > > https://lore.kernel.org/regressions/20230510141856.46532-1-hdegoede@redhat.com/ > > This patch is ready for merging and is waiting for the wireless-maintainer > to merge it and send it to Linus. > OK, thanks for the fixup! #regzbot fix: wifi: brcmfmac: Check for probe() id argument being NULL -- An old man doll... just what I always wanted! - Clara