From: Johannes Berg <johannes@sipsolutions.net>
To: Baochen Qiang <baochen.qiang@oss.qualcomm.com>,
Jose Ignacio Tornos Martinez <jtornosm@redhat.com>,
jjohnson@kernel.org
Cc: ath11k@lists.infradead.org, ath12k@lists.infradead.org,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] wifi: ath12k: fix MLO station firmware crash recovery
Date: Tue, 20 Oct 2026 10:39:46 +0200 [thread overview]
Message-ID: <b4c5587803cf01eb14a196d8968cc33d9c953f66.camel@sipsolutions.net> (raw)
In-Reply-To: <f0c329ad-a13e-4bd3-b630-c0137a5f42c9@oss.qualcomm.com>
On Tue, 2026-10-20 at 16:37 +0800, Baochen Qiang wrote:
> >
> > There might be a chance to disentangle the RTNL from this given the work
> > I did recently on disentangling it from cfg80211, but then on recovery
> > *failure* we have a problem with cfg80211_shutdown_all_interfaces().
>
> Hmm, I wonder whether the restart work could take rtnl only around
> cfg80211_shutdown_all_interfaces(). From a quick look,
> ieee80211_reconfig() itself mostly only needs the wiphy mutex, except
> ieee80211_add_virtual_monitor(), which asserts RTNL. Though any rtnl holder that then
> needs this wiphy would still end up stalling everyone while the recovery runs.
No, it's not that simple - it would have to drop the wiphy mutex to
acquire RTNL, but then userspace can come inbetween and use the failed
device.
johannes
next prev parent reply other threads:[~2026-10-20 8:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-04 17:49 [PATCH v2 0/3] wifi: ath12k: fixes to improve MLO station stability Jose Ignacio Tornos Martinez
2026-08-04 17:49 ` [PATCH v2 1/3] wifi: ath12k: fix MLO station firmware crash recovery Jose Ignacio Tornos Martinez
2026-10-15 5:51 ` Baochen Qiang
2026-10-17 8:04 ` [PATCH v2 1/3] wifi: ath12k: fixes to improve MLO station stability Jose Ignacio Tornos Martinez
2026-10-20 8:41 ` Baochen Qiang
2026-10-20 15:44 ` [PATCH v2 1/3] wifi: ath12k: fix MLO station firmware crash recovery Jose Ignacio Tornos Martinez
2026-10-17 9:33 ` Johannes Berg
2026-10-20 8:37 ` Baochen Qiang
2026-10-20 8:39 ` Johannes Berg [this message]
2026-08-04 17:50 ` [PATCH v2 2/3] wifi: ath12k: prevent scan during firmware recovery Jose Ignacio Tornos Martinez
2026-08-04 17:50 ` [PATCH v2 3/3] wifi: ath12k: skip connection_loss_work for MLO beacon miss Jose Ignacio Tornos Martinez
2026-09-17 7:42 ` [PATCH v2 0/3] wifi: ath12k: fixes to improve MLO station stability Jose Ignacio Tornos Martinez
2026-10-13 16:44 ` Jose Ignacio Tornos Martinez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4c5587803cf01eb14a196d8968cc33d9c953f66.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ath11k@lists.infradead.org \
--cc=ath12k@lists.infradead.org \
--cc=baochen.qiang@oss.qualcomm.com \
--cc=jjohnson@kernel.org \
--cc=jtornosm@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox