Linux wireless drivers development
 help / color / mirror / Atom feed
From: Ping-Ke Shih <pkshih@realtek.com>
To: Zenm Chen <zenmchen@gmail.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"rtl8821cerfe2@gmail.com" <rtl8821cerfe2@gmail.com>
Subject: RE: [PATCH] wifi: rtw88: Add support for Mercusys MA30N and D-Link DWA-T185 rev. A1
Date: Tue, 11 Feb 2025 06:20:15 +0000	[thread overview]
Message-ID: <b58fcb1185a24661a09d1eceeeda843a@realtek.com> (raw)
In-Reply-To: <20250211061541.1730-1-zenmchen@gmail.com>

> > By the way, these IDs aren't in increasing order, how did you pick IDs
> > from vendor driver?
> 
> Mikhail Novosyolov taught me a good command [1] to find out the missing
> USB IDs. :)
> 
> $ diff -u --color \
> <(modinfo a.ko | grep ^alias | sort -u) \
> <(modinfo b.ko | grep ^alias | sort -u)
> 
> [1] https://github.com/morrownr/88x2bu-20210702/issues/224#issuecomment-2404823387
> 

Cool. I thought you compared them with source code rather than binary code. 
So maybe it is not necessary to align them in source code. 


  reply	other threads:[~2025-02-11  6:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-10  7:36 [PATCH] wifi: rtw88: Add support for Mercusys MA30N and D-Link DWA-T185 rev. A1 Zenm Chen
2025-02-11  5:59 ` Ping-Ke Shih
2025-02-11  6:15   ` Zenm Chen
2025-02-11  6:20     ` Ping-Ke Shih [this message]
2025-02-21  1:27 ` Ping-Ke Shih

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b58fcb1185a24661a09d1eceeeda843a@realtek.com \
    --to=pkshih@realtek.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=rtl8821cerfe2@gmail.com \
    --cc=zenmchen@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox