From: Johannes Berg <johannes@sipsolutions.net>
To: Pablo MARTIN-GOMEZ <pmartin-gomez@freebox.fr>,
linux-wireless@vger.kernel.org
Cc: Miriam Rachel Korenblit <miriam.rachel.korenblit@intel.com>
Subject: Re: [PATCH 17/20] wifi: cfg80211: provide HT/VHT operation for AP beacon
Date: Wed, 15 Apr 2026 17:42:53 +0200 [thread overview]
Message-ID: <b5a0822b7ebf8e816e096e6a628db6b21fad40ef.camel@sipsolutions.net> (raw)
In-Reply-To: <ddfdac5d-602f-4f67-80bf-d41924b0b7e7@freebox.fr> (sfid-20260415_172238_311476_04A5EB08)
On Wed, 2026-04-15 at 17:22 +0200, Pablo MARTIN-GOMEZ wrote:
>
> > + * @ht_oper: HT operation element (or %NULL if HT isn't enabled)
> Might be some nitpicking you can ignore, but HT operation element is optional when HT is enabled. With the current comment, someone might (wrongly) deduce that if `ht_oper` is NULL then HT is not enabled.
>
Not sure how you mean that, but not really? If the AP has HT then it
must have HT operation, otherwise the clients can't use it?
johannes
next prev parent reply other threads:[~2026-04-15 15:42 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-15 12:41 [PATCH 00/20] wifi: mac80211: clean up and fix per-STA BW handling Johannes Berg
2026-04-15 12:41 ` [PATCH 01/20] wifi: mac80211: remove NAN guards on ieee80211_sta_cur_vht_bw() calls Johannes Berg
2026-04-15 12:42 ` [PATCH 02/20] wifi: mac80211: set cur_max_bandwidth to maximum Johannes Berg
2026-04-15 12:42 ` [PATCH 03/20] wifi: mac80211: use max BW for HT channel width update Johannes Berg
2026-04-15 12:42 ` [PATCH 04/20] wifi: mac80211: use chandef in ieee80211_get_sta_bw() Johannes Berg
2026-04-15 12:42 ` [PATCH 05/20] wifi: mac80211: use chandef in TDLS chanctx handling Johannes Berg
2026-04-15 12:42 ` [PATCH 06/20] wifi: mac80211: remove ieee80211_sta_cap_chan_bw() Johannes Berg
2026-04-15 12:42 ` [PATCH 07/20] wifi: nl80211: document channel opmode change channel width Johannes Berg
2026-04-15 12:42 ` [PATCH 08/20] wifi: mac80211: simplify ieee80211_sta_rx_bw_to_chan_width() Johannes Berg
2026-04-15 12:42 ` [PATCH 09/20] wifi: mac80211: clean up STA NSS handling Johannes Berg
2026-04-15 13:02 ` Johannes Berg
2026-04-15 12:42 ` [PATCH 10/20] wifi: mac80211: clean up initial STA NSS/bandwidth handling Johannes Berg
2026-04-15 12:42 ` [PATCH 11/20] wifi: mac80211: clean up ieee80211_sta_cap_rx_bw() Johannes Berg
2026-04-15 12:42 ` [PATCH 12/20] wifi: mac80211: remove ieee80211_sta_cur_vht_bw() Johannes Berg
2026-04-15 12:42 ` [PATCH 13/20] wifi: cfg80211: remove HE/SAE H2E required fields Johannes Berg
2026-04-15 12:42 ` [PATCH 14/20] wifi: nl80211: reject beacons with bad HE operation Johannes Berg
2026-04-20 13:44 ` Johannes Berg
2026-04-15 12:42 ` [PATCH 15/20] wifi: cfg80211: move AP HT/VHT/... operation to beacon info Johannes Berg
2026-04-15 12:42 ` [PATCH 16/20] wifi: nl80211: reject too short HT/VHT/HE/EHT capability/operation Johannes Berg
2026-04-15 12:42 ` [PATCH 17/20] wifi: cfg80211: provide HT/VHT operation for AP beacon Johannes Berg
2026-04-15 15:22 ` Pablo MARTIN-GOMEZ
2026-04-15 15:42 ` Johannes Berg [this message]
2026-04-15 16:02 ` Pablo MARTIN-GOMEZ
2026-04-15 16:05 ` Johannes Berg
2026-04-15 12:42 ` [PATCH 18/20] wifi: nl80211: always validate AP operation/PHY regulatory Johannes Berg
2026-04-15 12:42 ` [PATCH 19/20] wifi: mac80211: clarify per-STA bandwidth handling Johannes Berg
2026-04-15 12:42 ` [PATCH 20/20] wifi: mac80211: fix per-station PHY capability bandwidth Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5a0822b7ebf8e816e096e6a628db6b21fad40ef.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=miriam.rachel.korenblit@intel.com \
--cc=pmartin-gomez@freebox.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox