* [PATCH] rtw88: coex: remove useless if and else
@ 2020-12-22 12:28 Tian Tao
2020-12-30 3:46 ` Pkshih
0 siblings, 1 reply; 2+ messages in thread
From: Tian Tao @ 2020-12-22 12:28 UTC (permalink / raw)
To: tony0620emma, kvalo, davem, kuba; +Cc: linux-wireless, netdev
Fix the following coccinelle report:
drivers/net/wireless/realtek/rtw88/coex.c:1619:3-5: WARNING:
possible condition with no effect (if == else)
Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
---
drivers/net/wireless/realtek/rtw88/coex.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtw88/coex.c b/drivers/net/wireless/realtek/rtw88/coex.c
index 24530ca..df6676a 100644
--- a/drivers/net/wireless/realtek/rtw88/coex.c
+++ b/drivers/net/wireless/realtek/rtw88/coex.c
@@ -1616,12 +1616,7 @@ static void rtw_coex_action_bt_relink(struct rtw_dev *rtwdev)
if (efuse->share_ant) { /* Shared-Ant */
if (coex_stat->wl_gl_busy) {
table_case = 26;
- if (coex_stat->bt_hid_exist &&
- coex_stat->bt_profile_num == 1) {
- tdma_case = 20;
- } else {
- tdma_case = 20;
- }
+ tdma_case = 20;
} else {
table_case = 1;
tdma_case = 0;
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* RE: [PATCH] rtw88: coex: remove useless if and else
2020-12-22 12:28 [PATCH] rtw88: coex: remove useless if and else Tian Tao
@ 2020-12-30 3:46 ` Pkshih
0 siblings, 0 replies; 2+ messages in thread
From: Pkshih @ 2020-12-30 3:46 UTC (permalink / raw)
To: Tian Tao, tony0620emma@gmail.com, kvalo@codeaurora.org,
davem@davemloft.net, kuba@kernel.org
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org
> -----Original Message-----
> From: Tian Tao [mailto:tiantao6@hisilicon.com]
> Sent: Tuesday, December 22, 2020 8:29 PM
> To: tony0620emma@gmail.com; kvalo@codeaurora.org; davem@davemloft.net; kuba@kernel.org
> Cc: linux-wireless@vger.kernel.org; netdev@vger.kernel.org
> Subject: [PATCH] rtw88: coex: remove useless if and else
>
> Fix the following coccinelle report:
> drivers/net/wireless/realtek/rtw88/coex.c:1619:3-5: WARNING:
> possible condition with no effect (if == else)
>
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
> ---
> drivers/net/wireless/realtek/rtw88/coex.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/net/wireless/realtek/rtw88/coex.c b/drivers/net/wireless/realtek/rtw88/coex.c
> index 24530ca..df6676a 100644
> --- a/drivers/net/wireless/realtek/rtw88/coex.c
> +++ b/drivers/net/wireless/realtek/rtw88/coex.c
> @@ -1616,12 +1616,7 @@ static void rtw_coex_action_bt_relink(struct rtw_dev *rtwdev)
> if (efuse->share_ant) { /* Shared-Ant */
> if (coex_stat->wl_gl_busy) {
> table_case = 26;
> - if (coex_stat->bt_hid_exist &&
> - coex_stat->bt_profile_num == 1) {
> - tdma_case = 20;
> - } else {
> - tdma_case = 20;
> - }
> + tdma_case = 20;
> } else {
> table_case = 1;
> tdma_case = 0;
I found we miss something in these branches, so I sent a patch,
namely "rtw88: coex: set 4 slot TDMA for BT link and WL busy", to fix it.
The link is
https://patchwork.kernel.org/project/linux-wireless/patch/20201230033602.13636-1-pkshih@realtek.com/
---
Ping-Ke
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-12-30 3:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-22 12:28 [PATCH] rtw88: coex: remove useless if and else Tian Tao
2020-12-30 3:46 ` Pkshih
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).