From: Bob Copeland <me@bobcopeland.com>
To: Kalle Valo <kalle.valo@iki.fi>
Cc: linux-wireless@vger.kernel.org, Pavel Roskin <proski@gnu.org>,
Johannes Berg <johannes@sipsolutions.net>
Subject: Re: [PATCH] mac80211: fix tx select key null pointer crash with hostapd
Date: Sat, 23 Jan 2010 14:01:58 -0500 [thread overview]
Message-ID: <b6c5339f1001231101w46bbd5dbyae0e2a6607aa80f0@mail.gmail.com> (raw)
In-Reply-To: <20100123182714.15374.3093.stgit@tikku>
On Sat, Jan 23, 2010 at 1:27 PM, Kalle Valo <kalle.valo@iki.fi> wrote:
> Pavel Roskin reported a crash in ieee80211_tx_h_select_key():
>
> http://marc.info/?l=linux-wireless&m=126419655108528&w=2
>
> This is a regression from patch "mac80211: move control.hw_key assignment".
> Fix it as suggested by Johannes, adding an else statement to make sure
> that tx->key is not accessed when it's null.
>
> Compile-tested only.
>
> Reported-by: Pavel Roskin <proski@gnu.org>
> Cc: Johannes Berg <johannes@sipsolutions.net>
> Signed-off-by: Kalle Valo <kalle.valo@iki.fi>
Tested-by: Bob Copeland <me@bobcopeland.com>
Thanks!
--
Bob Copeland %% www.bobcopeland.com
next prev parent reply other threads:[~2010-01-23 19:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-23 18:27 [PATCH] mac80211: fix tx select key null pointer crash with hostapd Kalle Valo
2010-01-23 18:33 ` Kalle Valo
2010-01-23 19:01 ` Bob Copeland [this message]
2010-01-23 21:39 ` Markus Baier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6c5339f1001231101w46bbd5dbyae0e2a6607aa80f0@mail.gmail.com \
--to=me@bobcopeland.com \
--cc=johannes@sipsolutions.net \
--cc=kalle.valo@iki.fi \
--cc=linux-wireless@vger.kernel.org \
--cc=proski@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox