From: Johannes Berg <johannes@sipsolutions.net>
To: Jeff Chen <chunfan.chen@gmail.com>, linux-wireless@vger.kernel.org
Cc: lukas@wunner.de, briannorris@chromium.org, francesco@dolcini.it,
Jeff Chen <jeff.chen_1@nxp.com>
Subject: Re: [PATCH] wifi: mwifiex: append hotfix number to firmware version string
Date: Mon, 21 Sep 2026 10:53:48 +0200 [thread overview]
Message-ID: <b6da845800e730982ff8bce33070ad0af4025248.camel@sipsolutions.net> (raw)
In-Reply-To: <20260917032350.2323119-1-chunfan.chen@gmail.com>
On Thu, 2026-09-17 at 11:23 +0800, Jeff Chen wrote:
> +++ b/drivers/net/wireless/marvell/mwifiex/cmdevt.c
> @@ -1594,11 +1594,17 @@ int mwifiex_ret_get_hw_spec(struct mwifiex_private *priv,
> api_rev->major_ver,
> api_rev->minor_ver);
> break;
> - case FW_HOTFIX_VER_ID:
> + case FW_HOTFIX_VER_ID: {
> + struct hw_spec_fw_hotfix_ver *hf;
> +
> + hf = (void *)tlv;
> + adapter->fw_hotfix_ver =
> + le16_to_cpu(hf->hotfix_ver);
Add a length check before the LLMs complain ...
johannes
prev parent reply other threads:[~2026-09-21 8:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 3:23 [PATCH] wifi: mwifiex: append hotfix number to firmware version string Jeff Chen
2026-09-21 8:53 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6da845800e730982ff8bce33070ad0af4025248.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=briannorris@chromium.org \
--cc=chunfan.chen@gmail.com \
--cc=francesco@dolcini.it \
--cc=jeff.chen_1@nxp.com \
--cc=linux-wireless@vger.kernel.org \
--cc=lukas@wunner.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox