From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4BD3C43461 for ; Fri, 4 Sep 2020 16:57:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 786C22073B for ; Fri, 4 Sep 2020 16:57:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=candelatech.com header.i=@candelatech.com header.b="HycsRQs0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726722AbgIDQ5g (ORCPT ); Fri, 4 Sep 2020 12:57:36 -0400 Received: from mail2.candelatech.com ([208.74.158.173]:60562 "EHLO mail3.candelatech.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726135AbgIDQ5f (ORCPT ); Fri, 4 Sep 2020 12:57:35 -0400 Received: from [192.168.254.6] (unknown [50.34.202.127]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail3.candelatech.com (Postfix) with ESMTPSA id 92F9013C2B0; Fri, 4 Sep 2020 09:57:33 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 mail3.candelatech.com 92F9013C2B0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=candelatech.com; s=default; t=1599238653; bh=SyhC3/UZAlngc5dpNJUq1jy/e6JfB2N1qquj3+kbosw=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=HycsRQs0q0OwFgtYWA1MHxeieDwYf2Y1NfdYYEuPcm9JZQP5+RADtxaje9ybtH2SR AjGbf03P0u9hEDxU2o9mWleFwNgmyIejp3QnsW/0EocHfEeosh+9I7LKeQHaU0JeGv 4cPDI0XJCovrzrE2VUJmVcWcZy9BShWkWbHNxd28= Subject: Re: [PATCH] ath11k: Allow debugfs to work with 2+ radios installed. To: akolli@codeaurora.org Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, linux-wireless-owner@vger.kernel.org References: <20200903172359.29199-1-greearb@candelatech.com> <0101017459a1d409-4d95a8e1-d404-4fba-a25d-b2e3075947e0-000000@us-west-2.amazonses.com> <010101745a05a2fb-24c8bde9-c898-4d53-9416-b48a764f907b-000000@us-west-2.amazonses.com> From: Ben Greear Organization: Candela Technologies Message-ID: Date: Fri, 4 Sep 2020 09:57:33 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <010101745a05a2fb-24c8bde9-c898-4d53-9416-b48a764f907b-000000@us-west-2.amazonses.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-MW Content-Transfer-Encoding: 8bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 9/4/20 9:49 AM, akolli@codeaurora.org wrote: > On 2020-09-04 21:04, Ben Greear wrote: >> On 9/4/20 8:00 AM, akolli@codeaurora.org wrote: >>> On 2020-09-03 22:53, greearb@candelatech.com wrote: >>>> From: Ben Greear >>>> >>>> The code is trying to create an ath11k directory on debugfs >>>> root, but that fails when there is a second radio (and thus >>>> second instance of the driver). >>>> >>> >>> Hi Ben, >>> >>> IPQ8074 is soc and it does not need second debugfs entry, its on AHB. >>> QCA6390 is a pci card and multiple debug entries are needed if multiple cards are available, >>> I am planning to post a patch with bus specific abstraction function which creates single debugfs for soc based radios and multiple entries for PCI based >>> radios. >>> >>> AHB: >>> debugfs/ath11k/IPQ8074/ >>> >>> PCI >>> debugfs/ath11k/QCA6390_0001:01:00.0/ >>> debugfs/ath11k/QCA6390_0000:01:00.0/ >> >> I appreciate your feedback on this! >> >> Why not just stick with the way ath10k does, having the ath11k debugfs entry be >> under the phy debugfs directory? >> >> Maybe there is a high-level design document for the ath11k driver somewhere that >> explains how and why it is architected with the ath11k base object >> holding multiple >> phy objects? >> > > The initial ath11k driver was supporting IPQ8074, its an SOC and has 3-radios under wifi0, > - few entries in debugfs are common for SOC,all these are under >       debugfs/ath11k/IPQ8074/ >           "simulate_fw_crash" >           "soc_dp_stats" Ok, so one 8074 firmware instance is handling multiple radios, and if firmware crashes, then it would take down every radio at once? > - few entries are per radio, these are under >       debugfs/ath11k/IPQ8074/mac0/ >             "ext_tx_stats" >             "ext_rx_stats" >             "pktlog_filter" >       debugfs/ath11k/IPQ8074/mac1 >             "ext_tx_stats" >             "ext_rx_stats" >             "pktlog_filter" >       debugfs/ath11k/IPQ8074/mac2 >             "ext_tx_stats" >             "ext_rx_stats" >             "pktlog_filter" > >> And, very curious to know if you are able to get multiple QCA6390 NICs >> running on the >> same system, I'm seeing all sort of problems including NICs not always >> showing up in lspci >> and such. >> > I am not aware of this, like to understand the output of, qrtr-lookup cmd Based on my testing with debugs, whatever driver I pulled down from the ath tree had zero chance of working due to immediate crash. So, have you been able to test multiple 6390 radios yet? How do I do this qrtr-lookup command? Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com