From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7962C1F130A for ; Thu, 30 Jan 2025 19:03:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738263808; cv=none; b=UrpPwpoLSz2BJG4SdV+TTZjj9mdZrtBAYCe4en4IQI3oYxv+NqULLCVi3f852DV8t/QLhAimASW/lVK0brTEbM+nxQy6XCzTtV/41tfPZBBpphKWQDfLu5IFxIx01hUEEb0TGK7vg00wJk2xFMHqROG7gqnd9fe7m/wPKWKmk5Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738263808; c=relaxed/simple; bh=xA170475glyKqHvoyIBb2H8mhDD9eIw+YedUxI2I/Mk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Bf3ZCyzSrzNMVAH5gRCqYhSmC6WYgsByBI0iOLmUlLY7BZT8pKB52/Gj7ksmHAw8fVjX6TH4RiJg979s2lDXoKiYP5lfxQBQfyuCeYTKHiJPIIaVKCzw+LVH0ee0IFmTHvigdKTlJXun1ioOaw6d+P6dA5apj8F+SVoBr6MyvWE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=jWEKebLw; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="jWEKebLw" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 50UJ1o8J003767 for ; Thu, 30 Jan 2025 19:03:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 1+4dC9ic1NqLbtu8u4j5hpEPGFN8j5hgiRxsVCkLaMw=; b=jWEKebLwZHpKxBV2 RBapcT5V4s5pAMsgxvOHAJAh43QHgaLKnmvl+vu444OgUaG2QmeD/YuCkkFVUHW4 JgJti1SGN7hyQ1x7bz6dgC7wLWjYB4xCkZkABBYkVd1p6L3aklXpfNmiQSa7qLOn pJVTFj3+2XyMWhZS/w5XJdaIiX6aogbOqzNfLxpOGi6mYYiaxjQVmhtNZ6fDEMid aJZgYagfw9R3YtaeuNNeamRHLevAaduG2RxlK92dAVQJVAsPyhXa9ScOkzhTaOif aP6GpfeZKV3+etr/xIdGCh4muR2bUXxX+VTHFfr2S4md6yOqySYDf/lR1cr55elr 5DBLLA== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 44gf7m8075-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 30 Jan 2025 19:03:25 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2163d9a730aso23515755ad.1 for ; Thu, 30 Jan 2025 11:03:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738263804; x=1738868604; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1+4dC9ic1NqLbtu8u4j5hpEPGFN8j5hgiRxsVCkLaMw=; b=bDaXLWpdioZYgspm2t3UqABVChATdKmTbZQmeBpxhO5whgtqurLnxY55UuDIEF4eLu nPBzpI0k+NREguk9mzu0jV4/XhtMJPGcySaMCn9bG3c1MHVuX/rYwiynVw9V18wkiTKh ORSsDOvjAw/mbxA9HfKGT1BCWbxSNt1hNF6wuBqH/+y1CVT8MZgHeIBaqo/YLvOvPeeX NeRDqN0izYT1vZyBRPLQvkPh6WWfoWrCc8D7DC4RM6y7hpN3DPLv8WIRk42gwDq3l6h+ rMGneysQ3iHVf9rDTyWLRFQEi+dfQT0dVLQINlBaXWqawhUnTYMlAVc+2oygf3CaMF8A GLWg== X-Forwarded-Encrypted: i=1; AJvYcCWqX+98x/9+0R3Fq8vEqaGGo8AfsO7kSGvqBrDO5YjxvP54F/u8yzdZqzfyO5sY3rxHGLR0c8fumGcaG4KIYg==@vger.kernel.org X-Gm-Message-State: AOJu0Yz8uMXXMOOlqV9e2noEXs8MhAJOI5pG46wK4xp+36kBseS2b9fP 07of9cSG4Gyfpcrda65FUdwvnUUQcb93/mY9uUn3D+aCzbqMXYF51lEO0XjdPgjpOBk/Ow4PC5I uSpQ3yKsqWmieKopppuT/nXrHdkbPvofiYDRjykyS2pM7e3m5+3W0y8MVsCYvuAdrjw== X-Gm-Gg: ASbGncuu4xus+eE2I849aTif13ECNR2un4MMwYzVqeadtBywVF0duCHW/wYeqerKXz2 8NFMkTvrQUB2zYs01EyyVoesxlCg3VZgZ+kwJG9047g8RY/P72+71Zl13bwL0eTAMhes+M6S25P 6iVguS5/U8qmSBCqcRzhQ7E3WoIxczM+JXJ0T6P9HnQvQYJlmUmb5E1mmrd8oBZKSaQRdWTt/+G vWc/o6uRxWJBmRnnlCX3vMuLLBL1sp69JaYDYqG3aj1rz+zf598o3yY9nlWPN8HEB5loigSxMTG ALMVqRFjJmgqqPHPHED/8pUTJlHRSAWmAghRZDHCGPFpM7d8P0ocoEUV7sMPAGMapEfFQHwrtA= = X-Received: by 2002:a17:903:1c6:b0:215:9eac:1857 with SMTP id d9443c01a7336-21edd7d88c0mr9634015ad.5.1738263804005; Thu, 30 Jan 2025 11:03:24 -0800 (PST) X-Google-Smtp-Source: AGHT+IE5lOZnffNUyJ7KCfKAJLEwNSxmca+bnJfKkR1FK09cdyV4G4K0NyYO2pFGbFiPeZPx9BBARQ== X-Received: by 2002:a17:903:1c6:b0:215:9eac:1857 with SMTP id d9443c01a7336-21edd7d88c0mr9633645ad.5.1738263803605; Thu, 30 Jan 2025 11:03:23 -0800 (PST) Received: from [192.168.1.111] (c-73-202-227-126.hsd1.ca.comcast.net. [73.202.227.126]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21de32eba59sm17295815ad.147.2025.01.30.11.03.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Jan 2025 11:03:23 -0800 (PST) Message-ID: Date: Thu, 30 Jan 2025 11:03:21 -0800 Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 3/5] wifi: ath12k: add ath12k_hw_regs for IPQ5424 To: Krzysztof Kozlowski , Raj Kumar Bhagat Cc: ath12k@lists.infradead.org, linux-wireless@vger.kernel.org, Kalle Valo , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jeff Johnson , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Saravanakumar Duraisamy References: <20250130051838.1924079-1-quic_rajkbhag@quicinc.com> <20250130051838.1924079-4-quic_rajkbhag@quicinc.com> <20250130-groovy-competent-mastiff-19cc9e@krzk-bin> From: Jeff Johnson Content-Language: en-US In-Reply-To: <20250130-groovy-competent-mastiff-19cc9e@krzk-bin> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: vKE-IWTTlSM9V_HonRZqT1U2vDOXftf- X-Proofpoint-ORIG-GUID: vKE-IWTTlSM9V_HonRZqT1U2vDOXftf- X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-01-30_08,2025-01-30_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 spamscore=0 adultscore=0 phishscore=0 bulkscore=0 mlxlogscore=701 suspectscore=0 lowpriorityscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2501170000 definitions=main-2501300145 On 1/30/2025 12:38 AM, Krzysztof Kozlowski wrote: > On Thu, Jan 30, 2025 at 10:48:36AM +0530, Raj Kumar Bhagat wrote: >> From: Saravanakumar Duraisamy >> >> Add register addresses (ath12k_hw_regs) for new ath12k AHB based >> WiFi device IPQ5424. >> >> Tested-on: IPQ5424 hw1.0 AHB WLAN.WBE.1.5-01053-QCAHKSWPL_SILICONZ-1 >> Tested-on: IPQ5332 hw1.0 AHB WLAN.WBE.1.3.1-00130-QCAHKSWPL_SILICONZ-1 >> >> Signed-off-by: Saravanakumar Duraisamy >> Signed-off-by: Raj Kumar Bhagat >> --- >> drivers/net/wireless/ath/ath12k/hal.h | 3 + >> drivers/net/wireless/ath/ath12k/hw.c | 87 ++++++++++++++++++++++++++- >> 2 files changed, 89 insertions(+), 1 deletion(-) >> > > That's not a separate patch. Regs do not make any sense on their own, > so this commit makes no sense on its own. This approach was suggested during internal review so that each addition can be reviewed without distraction from the other pieces. None of this is actually enabled until the final patch, so "trickling in" the pieces seems preferable to me. /jeff