From: Luciano Coelho <luciano.coelho@intel.com>
To: "Grumbach, Emmanuel" <emmanuel.grumbach@intel.com>,
"dmoulding@me.com" <dmoulding@me.com>,
"kvalo@codeaurora.org" <kvalo@codeaurora.org>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
linuxwifi <linuxwifi@intel.com>,
"Berg, Johannes" <johannes.berg@intel.com>
Subject: Re: [PATCH v2 5.5] iwlwifi: mvm: Do not require PHY_SKU NVM section for 3168 devices
Date: Wed, 04 Mar 2020 11:06:18 +0200 [thread overview]
Message-ID: <b80b1af73554cb9d76d9814be40c61265c283cbf.camel@intel.com> (raw)
In-Reply-To: <eb6c6e1ff0e1c8c6b202e534262778a729923bc6.camel@intel.com>
On Thu, 2020-02-13 at 07:39 +0000, Grumbach, Emmanuel wrote:
> Hi Kalle and Dan,
>
> On Wed, 2020-02-12 at 16:46 +0200, Kalle Valo wrote:
> > Dan Moulding <dmoulding@me.com> writes:
> >
> > > This is just a friendly reminder that this patch has been
> > > submitted,
> > > for what looks like a fairly major regression in iwlwifi that
> > > impacts
> > > (as far as I can tell) *all* 3168 devices. The regression is in the
> > > v5.5.x series and was for a while back-ported to the stable trees,
> > > but
> > > luckily was noticed before the releases were made.
> > >
> > > There are at least a few bug reports for this regression:
> > >
> > > https://bugzilla.kernel.org/show_bug.cgi?id=206329
> > > https://bugs.gentoo.org/706810
> > > https://lkml.org/lkml/2020/2/7/811
> > > https://bbs.archlinux.org/viewtopic.php?id=252603
> > >
> > > The Gentoo maintainers have already applied this patch to their
> > > Linux
> > > sources and marked their bug report "fixed". But it would be really
> > > nice if we could get this regression fixed in the next stable
> > > v5.5.x
> > > release.
> >
> > I'll queue this directly to wireless-drivers. Intel folks, are you ok
> > with this?
> >
>
> The only person who really understand what goes on here is Luca, he is
> also the one who touched this area I think. Luca is OOO and should be
> back next week I believe.
> The patch looks sane and it fixes issues for people, so go ahead and
> merge it please. If Luca wants to make changes on top of this, he can
> ask to do those changes on top of that patch.
Thanks for the fix, discussions and merging while I was away! This
indeed looks correct and I'll take this patch to our internal tree now
to align it with the upstream code.
I guess this should be sent to stable v5.5 as well. Dan, would you
like to do that?
--
Cheers,
Luca.
next prev parent reply other threads:[~2020-03-04 9:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-28 9:31 [PATCH v2 5.5] iwlwifi: mvm: Do not require PHY_SKU NVM section for 3168 devices Dan Moulding
2020-02-11 16:24 ` Dan Moulding
2020-02-12 14:46 ` Kalle Valo
2020-02-13 7:39 ` Grumbach, Emmanuel
2020-03-04 9:06 ` Luciano Coelho [this message]
2020-03-04 15:58 ` Dan Moulding
2020-02-13 10:03 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b80b1af73554cb9d76d9814be40c61265c283cbf.camel@intel.com \
--to=luciano.coelho@intel.com \
--cc=dmoulding@me.com \
--cc=emmanuel.grumbach@intel.com \
--cc=johannes.berg@intel.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linuxwifi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).