From: Wen Gong <wgong@codeaurora.org>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2] ath10k: add fw coredump for sdio when firmware assert
Date: Mon, 23 Sep 2019 19:10:46 +0800 [thread overview]
Message-ID: <b8298efd20f3d05a38866b687f597c30@codeaurora.org> (raw)
In-Reply-To: <87zhixamyp.fsf@codeaurora.org>
On 2019-09-21 19:49, Kalle Valo wrote:
> After looking more closely, the ar->bmi.done_set checks in bmi.c does
> not look necessary to me, I have never seen that warning. I would
> remove
> those and the done_sent field altogether from ath10k to make the code
> cleaner and I avoid hacks like above. This should be done in a separate
> patch, of course.
so I will use it this patch :)
prev parent reply other threads:[~2019-09-23 11:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-30 2:32 [PATCH v2] ath10k: add fw coredump for sdio when firmware assert Wen Gong
2019-09-21 11:26 ` Kalle Valo
2019-09-21 11:35 ` Kalle Valo
2019-09-23 11:07 ` Wen Gong
2019-09-24 3:38 ` Wen Gong
2019-09-21 11:38 ` Kalle Valo
2019-09-23 11:09 ` Wen Gong
2019-09-23 11:37 ` Kalle Valo
2019-09-23 12:12 ` Wen Gong
2019-09-21 11:49 ` Kalle Valo
2019-09-23 11:10 ` Wen Gong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8298efd20f3d05a38866b687f597c30@codeaurora.org \
--to=wgong@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).