RE: [PATCH v4 03/14] wifi: rtlwifi: Move code from rtl8192de to rtl8192d-common

[Ping-Ke Shih <pkshih@realtek.com>]

Bitterblue Smith <rtl8821cerfe2@gmail.com> wrote:

> On 12/04/2024 11:22, Ping-Ke Shih wrote:
> > Bitterblue Smith <rtl8821cerfe2@gmail.com> wrote:
> >
> >> diff --git a/drivers/net/wireless/realtek/rtlwifi/Kconfig
> >> b/drivers/net/wireless/realtek/rtlwifi/Kconfig
> >> index 9f6a4e35543c..2319eaa8845a 100644
> >> --- a/drivers/net/wireless/realtek/rtlwifi/Kconfig
> >> +++ b/drivers/net/wireless/realtek/rtlwifi/Kconfig
> >> @@ -37,6 +37,7 @@ config RTL8192SE
> >>  config RTL8192DE
> >>         tristate "Realtek RTL8192DE/RTL8188DE PCIe Wireless Network Adapter"
> >>         depends on PCI
> >> +       select RTL8192D_COMMON
> >>         select RTLWIFI
> >>         select RTLWIFI_PCI
> >>         help
> >> @@ -142,6 +143,11 @@ config RTL8192C_COMMON
> >>         depends on RTL8192CE || RTL8192CU
> >>         default y
> >>
> >> +config RTL8192D_COMMON
> >> +       tristate
> >> +       depends on RTL8192DE
> >> +       default y
> >> +
> >
> > Existing RTL8723_COMMON also uses both 'depends on' and 'select', which are
> > mutual reference, so I think choosing only one of them would be better.
> >
> >>  config RTL8723_COMMON
> >>         tristate
> >>         depends on RTL8723AE || RTL8723BE
> >
> 
> I'm not sure about this. Isn't there a good reason why the
> "common" drivers do it this way?
> 
> [...]

IIRC people said mutual reference of 'depends on' and 'select' isn't good. 
(I can't find that discussion, sorry.)

I think we can add 'select RTL8192D_COMMON' to RTL8192DE, and

config RTL8192D_COMMON
	tristate
	(no need 'depends on' and 'default y')

> Okay, I did all the things you mentioned, and a bit more.

Thanks for extra works. I believe there are more works than I mentioned. :)
And, these works should be verified by real hardware because of many changes,
so I think this is a good time to refine this driver, because you are
verifying new hardware.