From: Johannes Berg <johannes@sipsolutions.net>
To: Amar Singhal <asinghal@codeaurora.org>, jouni@codeaurora.org
Cc: linux-wireless@vger.kernel.org, jjohnson@codeaurora.org,
rmanohar@codeaurora.org
Subject: Re: [PATCH] cfg80211: Add new fields to wiphy structure
Date: Fri, 30 Aug 2019 09:19:16 +0200 [thread overview]
Message-ID: <b97b57bdd07fa5cfdc07d5fd451d506b20e0cd0e.camel@sipsolutions.net> (raw)
In-Reply-To: <1567116559-17419-1-git-send-email-asinghal@codeaurora.org>
On Thu, 2019-08-29 at 15:09 -0700, Amar Singhal wrote:
> A channel is completely defined by (oper_class, channel number) tuple,
> and not just by center frequency. Operating class also tells about the
> bandwidth supported by the channel. Therefore add the operating class and
> channel number to the wiphy structure.
We don't split out the channels that way, so this doesn't seem like the
right approach.
Instead, we list the *frequencies*, and then have flags for the
permitted bandwidths. We already support things like "no-HT40+" and
could possibly extend that to others, if it were _really_ possible,
though in practice those limitations are usually not present in devices,
just in the spec, and we can rely on hostapd/wpa_s to take care of them.
Even if you do have those limitations, this isn't the right way to go
about it, because it'll be very confusing to userspace to see the same
frequency multiple times. It'd also cause a bunch of problems with
scanning (listing the same channel twice) etc.
Since you haven't explained why you want to do this I cannot offer any
further guidance, but this cannot be the right approach.
johannes
prev parent reply other threads:[~2019-08-30 7:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-29 22:09 [PATCH] cfg80211: Add new fields to wiphy structure Amar Singhal
2019-08-30 7:19 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b97b57bdd07fa5cfdc07d5fd451d506b20e0cd0e.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=asinghal@codeaurora.org \
--cc=jjohnson@codeaurora.org \
--cc=jouni@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rmanohar@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox