From: Stefan Hansson <newbyte@postmarketos.org>
To: Johannes Berg <johannes@sipsolutions.net>,
Stefan Hansson <newbie13xd@gmail.com>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
phone-devel@vger.kernel.org
Subject: Re: [PATCH] wifi: rsi: Fix types to appease CFI
Date: Sun, 2 Aug 2026 20:40:21 +0200 [thread overview]
Message-ID: <ba0fbf6a-024d-425c-aed3-ab0ee67246d4@postmarketos.org> (raw)
In-Reply-To: <a0ab921cb2172a07b37d2a221917a78ba6e14da0.camel@sipsolutions.net>
Hello Johannes,
On 02/08/2026 18:24, Johannes Berg wrote:
> On Sun, 2026-08-02 at 14:22 +0200, Stefan Hansson wrote:
>> Avoids errors like:
>>
>> CFI failure at kthread+0x124/0x1cc (target: rsi_coex_scheduler_thread+0x0/0x1b4 [redpine_91x]; expected type: 0x89fb613d)
>
> Yeah, well. Everyone gets _one_ warning to send patches that actually
> build warning-free, after that I just drop them without notice...
Could you clarify what you are referring to here? I don't get any errors
when building after applying this patch on top of next-20260730:
$ make -j4
make: Entering directory '/mnt/linux'
make[1]: Entering directory '/mnt/linux/.output'
CC [M] drivers/net/wireless/rsi/rsi_91x_main.o
CC [M] drivers/net/wireless/rsi/rsi_91x_core.o
CC [M] drivers/net/wireless/rsi/rsi_91x_mac80211.o
CC [M] drivers/net/wireless/rsi/rsi_91x_mgmt.o
CC [M] drivers/net/wireless/rsi/rsi_91x_hal.o
CC [M] drivers/net/wireless/rsi/rsi_91x_ps.o
CC [M] drivers/net/wireless/rsi/rsi_91x_coex.o
CC [M] drivers/net/wireless/rsi/rsi_91x_debugfs.o
CC [M] drivers/net/wireless/rsi/rsi_91x_sdio.o
CC [M] drivers/net/wireless/rsi/rsi_91x_sdio_ops.o
CC [M] drivers/net/wireless/rsi/rsi_91x_usb.o
CC [M] drivers/net/wireless/rsi/rsi_91x_usb_ops.o
LD [M] drivers/net/wireless/rsi/rsi_91x.o
LD [M] drivers/net/wireless/rsi/rsi_sdio.o
LD [M] drivers/net/wireless/rsi/rsi_usb.o
MODPOST Module.symvers
CC [M] drivers/net/wireless/rsi/rsi_91x.mod.o
CC [M] drivers/net/wireless/rsi/rsi_sdio.mod.o
CC [M] drivers/net/wireless/rsi/rsi_usb.mod.o
LD [M] drivers/net/wireless/rsi/rsi_usb.ko
LD [M] drivers/net/wireless/rsi/rsi_sdio.ko
LD [M] drivers/net/wireless/rsi/rsi_91x.ko
make[1]: Leaving directory '/mnt/linux/.output'
make: Leaving directory '/mnt/linux'
FWIW I am building using Clang/LLVM.
If you are referring to checkpatch.pl complaining about the
aforementioned error line being too long, I can wrap it if you prefer that.
> johannes
Stefan Hansson
next prev parent reply other threads:[~2026-08-02 18:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260802-rsi-cfi-fix-v1-1-5821d2cb54ee@postmarketos.org>
2026-08-02 14:30 ` [PATCH] wifi: rsi: Fix types to appease CFI Jeff Johnson
2026-08-02 18:44 ` Stefan Hansson
2026-08-02 16:24 ` Johannes Berg
2026-08-02 18:40 ` Stefan Hansson [this message]
2026-08-02 18:52 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba0fbf6a-024d-425c-aed3-ab0ee67246d4@postmarketos.org \
--to=newbyte@postmarketos.org \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=newbie13xd@gmail.com \
--cc=phone-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox