Re: [PATCH] wifi: cfg80211: reinit wiphy work entries on runaway drain

[Ben Greear <greearb@candelatech.com>]

On 7/7/26 08:47, Cen Zhang wrote:
> Hi Ben,
> 
> Thanks for your review and comments.
> 
>> Even this likely leaves the system in a bad state since requested work
>> items would be skipped.  Probably should also increase runaway_limit quite
>> a bit as well (that has worked OK for me), maybe remove it entirely.
> 
> Fair. Hitting the guard still means pending work gets skipped; this patch only
> avoids leaving those work entries with stale list links after the
> existing drop path.
> 
> I was hesitant to remove the guard in the same change, because the
> flush-all paths run under the wiphy mutex, and a work item that keeps
> requeueing itself could otherwise keep flush, suspend, or unregister
> stuck there. Raising the limit sounds less risky, but I would want a
> concrete reason for the new value rather than picking one arbitrarily..

Yeah, you have a good point.  I'm not sure of a proper solution.  I set my limit to 200
and was no longer able to reproduce warning splats.

Your patch may certainly be an improvement.

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com