From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BE8BEB64D9 for ; Wed, 14 Jun 2023 07:34:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243343AbjFNHeG (ORCPT ); Wed, 14 Jun 2023 03:34:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49520 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235414AbjFNHeB (ORCPT ); Wed, 14 Jun 2023 03:34:01 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A6AFBE62; Wed, 14 Jun 2023 00:34:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=MIME-Version:Content-Transfer-Encoding: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=/ux0V+hWpeqZe1y6Lv0wFsb0Uq7wh+rm8EMEdQa6UWo=; t=1686728040; x=1687937640; b=XXxC/lfv3V4KdPXsq5JEyIrE7wTw1Whrk1J98ady22jRjmg IlaueyK02wtP9MI6kpxIY25I+ShlX6yhThv0dDQeKa8V3lVk0L05nj9jLOYOIyvAmmh7m/zqqN4jI XG789tczscFmBnN9m616m6yk19cnASCn82i9l3RQiHbHC26mhOvDj5WyzWGfYxrMjKAKdOnDE7SFf z9588qNlH2EVAleKR4o1VC3NQNqDNir9J6qQKrk+9GJpQ93G2NaF7UWMisjrmtAPZtirF/S749zge 0WriF/r9NKn1j9UIswTsHYtQpTAv4ybPKCWPV7v1syKXYKJMfbP4FS2GohR6B9wQ==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.96) (envelope-from ) id 1q9L0l-005yrq-2x; Wed, 14 Jun 2023 09:33:47 +0200 Message-ID: Subject: Re: [PATCH] b43legacy: Remove unneeded variable From: Johannes Berg To: wuyonggang001@208suo.com, Larry.Finger@lwfinger.net, kvalo@kernel.org Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 14 Jun 2023 09:33:46 +0200 In-Reply-To: <5e1b466986b2371f71f99d7123f1de6d@208suo.com> References: <20230612044742.58785-1-zhanglibing@cdjrlc.com> <2caa7e16691b9cecab28aec323785a35@208suo.com> <5e1b466986b2371f71f99d7123f1de6d@208suo.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.3 (3.48.3-1.fc38) MIME-Version: 1.0 X-malware-bazaar: not-scanned Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Wed, 2023-06-14 at 13:52 +0800, wuyonggang001@208suo.com wrote: > Fix the following coccicheck warning: >=20 > drivers/net/wireless/broadcom/b43legacy/debugfs.c:68:9-14: Unneeded=20 > variable: "count". That may be a warning that it gives. > Signed-off-by: Yonggang Wu > --- > drivers/net/wireless/broadcom/b43legacy/debugfs.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/drivers/net/wireless/broadcom/b43legacy/debugfs.c=20 > b/drivers/net/wireless/broadcom/b43legacy/debugfs.c > index 6b0e8d117061..55a067eaa52d 100644 > --- a/drivers/net/wireless/broadcom/b43legacy/debugfs.c > +++ b/drivers/net/wireless/broadcom/b43legacy/debugfs.c > @@ -73,7 +73,7 @@ static ssize_t tsf_read_file(struct b43legacy_wldev=20 > *dev, char *buf, size_t bufs > (unsigned int)((tsf & 0xFFFFFFFF00000000ULL) >> 32), > (unsigned int)(tsf & 0xFFFFFFFFULL)); >=20 > - return count; > + return 0; >=20 However, that doesn't even fix the warning, and it is actually also completely wrong. Please don't submit patches where you don't even understand the code. johannes