From: Ping-Ke Shih <pkshih@realtek.com>
To: "luka.gejak@linux.dev" <luka.gejak@linux.dev>,
Kalle Valo <kvalo@kernel.org>
Cc: Sascha Hauer <s.hauer@pengutronix.de>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: RE: [PATCH v3] wifi: rtw88: usb: fix memory leaks on USB write failures
Date: Mon, 18 May 2026 07:10:45 +0000 [thread overview]
Message-ID: <bb6711f7f94544e69c031925133f9bf5@realtek.com> (raw)
In-Reply-To: <20260513181008.13470-1-luka.gejak@linux.dev>
> @@ -456,7 +457,13 @@ static bool rtw_usb_tx_agg_skb(struct rtw_usb *rtwusb, struct sk_buff_head *list
> tx_desc = (struct rtw_tx_desc *)skb_head->data;
> qsel = le32_get_bits(tx_desc->w1, RTW_TX_DESC_W1_QSEL);
>
> - rtw_usb_write_port(rtwdev, qsel, skb_head, rtw_usb_write_port_tx_complete, txcb);
> + ret = rtw_usb_write_port(rtwdev, qsel, skb_head,
> + rtw_usb_write_port_tx_complete, txcb);
ERROR: code indent should use tabs where possible
#54: FILE: drivers/net/wireless/realtek/rtw88/usb.c:461:
+^I^I^I rtw_usb_write_port_tx_complete, txcb);$
CHECK: Alignment should match open parenthesis
#54: FILE: drivers/net/wireless/realtek/rtw88/usb.c:461:
+ ret = rtw_usb_write_port(rtwdev, qsel, skb_head,
+ rtw_usb_write_port_tx_complete, txcb);
Please correct them and resend v4. (You can take my acked-by in v3)
> + if (ret) {
> + ieee80211_purge_tx_queue(rtwdev->hw, &txcb->tx_ack_queue);
> + kfree(txcb);
> + return false;
> + }
>
> return true;
> }
prev parent reply other threads:[~2026-05-18 7:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 18:10 [PATCH v3] wifi: rtw88: usb: fix memory leaks on USB write failures luka.gejak
2026-05-14 1:14 ` Ping-Ke Shih
2026-05-18 7:10 ` Ping-Ke Shih [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb6711f7f94544e69c031925133f9bf5@realtek.com \
--to=pkshih@realtek.com \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luka.gejak@linux.dev \
--cc=s.hauer@pengutronix.de \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox