Re: [PATCH rtw-next] wifi: rtw88: sdio: limit the high queue to DTIM delivery

["Luka Gejak" <luka.gejak@linux.dev>]

October 21, 2026 at 6:23 AM, "Luka Gejak" <luka.gejak@linux.dev> wrote:


> 
> October 21, 2026 at 3:34 AM, "Ping-Ke Shih" <pkshih@realtek.com> wrote:
> 
> > 
> > Luka Gejak <luka.gejak@linux.dev> wrote:
> >  
> >  
[...]
> >  This is totally the same as USB. To share with USB, move it to tx.c 
> >  as an export function or to tx.h as an inline function.
> > 
> I am aware of that, but ai wasn't sure

                          *I wasn't sure

 what is preferred approach so I
> resorted to changing as little shared code as possible to mitigate the
> risk of regression on other drivers. I will make it shared between USB
> and SDIO.
> 
> > 
> > +
> >  +static bool rtw_sdio_hiq_take_budget(struct rtw_sdio *rtwsdio)
> >  +{
> >  + unsigned long flags, elapsed, add;
> >  + bool ok;
> >  +
> >  + spin_lock_irqsave(&rtwsdio->hiq_lock, flags);
> >  +
> >  + elapsed = jiffies - rtwsdio->hiq_refill;
> >  + add = elapsed / RTW_SDIO_HIQ_REFILL_INTERVAL;
> >  + if (add) {
> >  + rtwsdio->hiq_budget = min_t(unsigned long,
> >  + rtwsdio->hiq_budget + add,
> >  + RTW_SDIO_HIQ_BUDGET_MAX);
> >  +
> >  + /* keep the unfinished part of the interval for the next unit */
> >  + rtwsdio->hiq_refill = jiffies -
> >  + elapsed % RTW_SDIO_HIQ_REFILL_INTERVAL;
> >  + }
> >  +
> >  + ok = rtwsdio->hiq_budget > 0;
> >  + if (ok)
> >  + rtwsdio->hiq_budget--;
> >  +
> >  + spin_unlock_irqrestore(&rtwsdio->hiq_lock, flags);
> >  +
> >  + return ok;
> >  +}
> >  
> >  This is also the same as USB. Please consider how to share the logic.
> > 
> Same as above.
> 
> Best regards,
> Luka Gejak
>