From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17569C04AB5 for ; Thu, 6 Jun 2019 22:12:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CD1692064A for ; Thu, 6 Jun 2019 22:12:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=candelatech.com header.i=@candelatech.com header.b="qAnqpMVs" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729013AbfFFWMl (ORCPT ); Thu, 6 Jun 2019 18:12:41 -0400 Received: from mail2.candelatech.com ([208.74.158.173]:38778 "EHLO mail3.candelatech.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726837AbfFFWMk (ORCPT ); Thu, 6 Jun 2019 18:12:40 -0400 Received: from [192.168.100.195] (50-251-239-81-static.hfc.comcastbusiness.net [50.251.239.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail3.candelatech.com (Postfix) with ESMTPSA id 0418913C283 for ; Thu, 6 Jun 2019 15:12:39 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 mail3.candelatech.com 0418913C283 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=candelatech.com; s=default; t=1559859160; bh=8QSUWnElWxKMhxnPCYbkDI2DecFkYqoNBA/kWv/icLA=; h=Subject:From:To:References:Date:In-Reply-To:From; b=qAnqpMVsXI9S57yUwARo4rUhOILMq+yRJ5uS13KW9MqOOn81djkIGAeRx12RGkoFh 3tPWmH1V8n//Ig4SYieC/cM6VkL3SfRflkkTAEFGUBUy2EPT3Ss358RdDtpa2ziIxc 3Tit30ybkhvMV/24sV8pV7fFtJ/3cFIVBMsDlSyI= Subject: Re: Help with encrypting PMF management frames From: Ben Greear To: "linux-wireless@vger.kernel.org" References: Organization: Candela Technologies Message-ID: Date: Thu, 6 Jun 2019 15:12:39 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 6/6/19 9:54 AM, Ben Greear wrote: > Hello, > > My variant of ath10k uses the normal 'native-wifi' tx path for management frames. > Internally in the firmware, it seems that the management TID is flagged to expect > raw frames, and I think that is why I see Action frames on-air that are not actually > encrypted but which have some space added to their packet that should be filled in by > the hw-crypt engine. > > Is there a way to get mac80211 to software-crypt just management-tid PMF frames? > > So far, I have not been able to find the correct place in the tx logic of > mac80211... > > Thanks, > Ben > Ok, I found the issue. It seems the ath10k hardware refuses to encrypt management frames unless they are sent in RAW mode (nwifi mgt frames are sent w/out encryption for whatever reason). So, the fix is in the ath10k driver (and just my driver I suppose, stock driver uses a different API for mgt frames that eventually is raw-tx down in the firmware). Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com