From: Bitterblue Smith <rtl8821cerfe2@gmail.com>
To: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc: Jes Sorensen <Jes.Sorensen@gmail.com>
Subject: [PATCH v3 3/5] wifi: rtl8xxxu: Recognise all possible chip cuts
Date: Fri, 28 Oct 2022 19:37:04 +0300 [thread overview]
Message-ID: <bded398b-322d-0e70-c058-62b1a6115bed@gmail.com> (raw)
In-Reply-To: <d1cfc9ef-dfc1-b3dc-c471-fe18aee8962e@gmail.com>
The chip cut, also known as the chip version, is a letter from A (0)
to P (15). Recognise them all instead of printing "unknown" when it's
greater than E.
Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>
---
v3:
- No change.
v2:
- Suggestion from Ping-Ke Shih:
- Don't use array of letters.
---
.../wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 26 ++++---------------
1 file changed, 5 insertions(+), 21 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
index 861c33a6d7f9..64062f18a5a0 100644
--- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
+++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
@@ -1574,30 +1574,14 @@ rtl8xxxu_set_spec_sifs(struct rtl8xxxu_priv *priv, u16 cck, u16 ofdm)
static void rtl8xxxu_print_chipinfo(struct rtl8xxxu_priv *priv)
{
struct device *dev = &priv->udev->dev;
- char *cut;
+ char cut = '?';
- switch (priv->chip_cut) {
- case 0:
- cut = "A";
- break;
- case 1:
- cut = "B";
- break;
- case 2:
- cut = "C";
- break;
- case 3:
- cut = "D";
- break;
- case 4:
- cut = "E";
- break;
- default:
- cut = "unknown";
- }
+ /* Currently always true: chip_cut is 4 bits. */
+ if (priv->chip_cut <= 15)
+ cut = 'A' + priv->chip_cut;
dev_info(dev,
- "RTL%s rev %s (%s) %iT%iR, TX queues %i, WiFi=%i, BT=%i, GPS=%i, HI PA=%i\n",
+ "RTL%s rev %c (%s) %iT%iR, TX queues %i, WiFi=%i, BT=%i, GPS=%i, HI PA=%i\n",
priv->chip_name, cut, priv->chip_vendor, priv->tx_paths,
priv->rx_paths, priv->ep_tx_count, priv->has_wifi,
priv->has_bluetooth, priv->has_gps, priv->hi_pa);
--
2.38.0
next prev parent reply other threads:[~2022-10-28 16:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-28 16:30 [PATCH v3 1/5] wifi: rtl8xxxu: Add central frequency offset tracking Bitterblue Smith
2022-10-28 16:36 ` [PATCH v3 2/5] wifi: rtl8xxxu: Fix the CCK RSSI calculation Bitterblue Smith
2022-10-31 1:07 ` Ping-Ke Shih
2022-10-28 16:37 ` Bitterblue Smith [this message]
2022-10-31 1:08 ` [PATCH v3 3/5] wifi: rtl8xxxu: Recognise all possible chip cuts Ping-Ke Shih
2022-10-28 16:38 ` [PATCH v3 4/5] wifi: rtl8xxxu: Set IEEE80211_HW_SUPPORT_FAST_XMIT Bitterblue Smith
2022-10-31 1:08 ` Ping-Ke Shih
2022-10-28 16:40 ` [PATCH v3 5/5] wifi: rtl8xxxu: Use dev_info instead of pr_info Bitterblue Smith
2022-10-31 1:09 ` Ping-Ke Shih
2022-11-01 11:11 ` Kalle Valo
2022-11-01 17:49 ` Bitterblue Smith
2022-10-31 1:07 ` [PATCH v3 1/5] wifi: rtl8xxxu: Add central frequency offset tracking Ping-Ke Shih
2022-11-01 11:09 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bded398b-322d-0e70-c058-62b1a6115bed@gmail.com \
--to=rtl8821cerfe2@gmail.com \
--cc=Jes.Sorensen@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).