Linux wireless drivers development
 help / color / mirror / Atom feed
From: "Johannes Berg" <johannes@sipsolutions.net>
To: "Luis R. Rodriguez" <lrodriguez@atheros.com>
Cc: linville@tuxdriver.com,
	"Luis R. Rodriguez" <lrodriguez@atheros.com>,
	linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/6] cfg80211: a reg rule is invalid if freq diff is 0
Date: Thu, 30 Oct 2008 10:22:42 +0100 (CET)	[thread overview]
Message-ID: <be0976f315094fc29b6d0ee915f8026a.squirrel@secure.sipsolutions.net> (raw)
In-Reply-To: <1225329594-21704-2-git-send-email-lrodriguez@atheros.com>

Luis R. Rodriguez wrote:
> A regulatory rule is invalid when the frequency difference
> between the end of the frequency range and the start is 0.
>
> Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
> ---
>  net/wireless/reg.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/net/wireless/reg.c b/net/wireless/reg.c
> index 9dff716..ff706f9 100644
> --- a/net/wireless/reg.c
> +++ b/net/wireless/reg.c
> @@ -321,7 +321,7 @@ static bool is_valid_reg_rule(const struct
> ieee80211_reg_rule *rule)
>
>  	freq_diff = freq_range->end_freq_khz - freq_range->start_freq_khz;
>
> -	if (freq_range->max_bandwidth_khz > freq_diff)
> +	if (freq_diff == 0 || freq_range->max_bandwidth_khz > freq_diff)

Might want to make that <= 0 just in case?

johannes

  parent reply	other threads:[~2008-10-30  9:22 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-30  1:19 [PATCH 0/6] cfg80211: few regulatory updates Luis R. Rodriguez
2008-10-30  1:19 ` [PATCH 1/6] cfg80211: a reg rule is invalid if freq diff is 0 Luis R. Rodriguez
2008-10-30  1:19   ` [PATCH 2/6] cfg80211: Add regulatory domain intersection capability Luis R. Rodriguez
2008-10-30  1:19     ` [PATCH 3/6] cfg80211: make print_regdomain_info() static Luis R. Rodriguez
2008-10-30  1:19       ` [PATCH 4/6] cfg80211: make use of reg macros on REG_RULE Luis R. Rodriguez
2008-10-30  1:19         ` [PATCH 5/6] cfg80211: Add kdoc for struct regulatory_request Luis R. Rodriguez
2008-10-30  1:19           ` [PATCH 6/6] cfg80211: enable 5 GHz band for world regulatory domain Luis R. Rodriguez
2008-10-30  9:24             ` Johannes Berg
2008-10-30 16:09               ` Luis R. Rodriguez
2008-10-30 17:18                 ` Johannes Berg
2008-10-30 17:43                   ` Luis R. Rodriguez
2008-10-30 18:12                   ` Jouni Malinen
2008-10-30  9:22   ` Johannes Berg [this message]
2008-10-30 19:40     ` [PATCH 1/6] cfg80211: a reg rule is invalid if freq diff is 0 Luis R. Rodriguez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=be0976f315094fc29b6d0ee915f8026a.squirrel@secure.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=lrodriguez@atheros.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox