From: Rajkumar Manoharan <rmanohar@codeaurora.org>
To: "Valo, Kalle" <kvalo@qca.qualcomm.com>
Cc: "Manoharan, Rajkumar" <rmanohar@qti.qualcomm.com>,
ath10k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ath10k: remove MSI range support
Date: Tue, 05 Apr 2016 19:06:25 +0530 [thread overview]
Message-ID: <be237b11cdc2472b67a1fd58e7860938@codeaurora.org> (raw)
In-Reply-To: <87oa9ob4m0.fsf@kamboji.qca.qualcomm.com>
On 2016-04-05 18:21, Valo, Kalle wrote:
> Rajkumar Manoharan <rmanohar@qti.qualcomm.com> writes:
>
>> MSI-X is never well-tested, might contain bugs and generally isn't
>> really all that useful to maintain. Also ath10k is mainly used with
>> shared/singly-MSI interrupt systems. Hence removing MSI range support.
>> This change will be useful for further cleanup in copy engine lock
>> and to add NAPI support.
>>
>> Signed-off-by: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
>
> [...]
>
>> @@ -171,14 +168,10 @@ struct ath10k_pci {
>> void __iomem *mem;
>> size_t mem_len;
>>
>> - /*
>> - * Number of MSI interrupts granted, 0 --> using legacy PCI line
>> - * interrupts.
>> - */
>> - int num_msi_intrs;
>> + /* Operating interrupt mode */
>> + u8 oper_irq_mode;
>
> Shouldn't this be enum ath10k_pci_irq_mode?
Yes.. Then the enum should be moved to pci.h. will send next version
-Rajkumar
prev parent reply other threads:[~2016-04-05 13:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-31 12:15 [PATCH] ath10k: remove MSI range support Rajkumar Manoharan
2016-04-05 12:51 ` Valo, Kalle
2016-04-05 13:36 ` Rajkumar Manoharan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be237b11cdc2472b67a1fd58e7860938@codeaurora.org \
--to=rmanohar@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=rmanohar@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).