From: Rameshkumar Sundaram <rameshkumar.sundaram@oss.qualcomm.com>
To: Raj Kumar Bhagat <raj.bhagat@oss.qualcomm.com>,
Johannes Berg <johannes@sipsolutions.net>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Jeff Johnson <jjohnson@kernel.org>
Cc: linux-wireless@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, ath12k@lists.infradead.org,
Saravanakumar Duraisamy <quic_saradura@quicinc.com>,
Baochen Qiang <baochen.qiang@oss.qualcomm.com>
Subject: Re: [PATCH ath-next v5 4/6] wifi: ath12k: add ath12k_hw_regs for IPQ5424
Date: Tue, 7 Apr 2026 21:52:30 +0530 [thread overview]
Message-ID: <be871892-cb95-4316-bdf4-4609f1c46d0b@oss.qualcomm.com> (raw)
In-Reply-To: <20260407-ath12k-ipq5424-v5-4-8e96aa660ec4@oss.qualcomm.com>
On 4/7/2026 10:56 AM, Raj Kumar Bhagat wrote:
> From: Saravanakumar Duraisamy <quic_saradura@quicinc.com>
>
> Add register addresses (ath12k_hw_regs) for ath12k AHB based
> WiFi 7 device IPQ5424.
>
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.6-01243-QCAHKSWPL_SILICONZ-1
> Tested-on: IPQ5332 hw1.0 AHB WLAN.WBE.1.6-01275-QCAHKSWPL_SILICONZ-1
> Tested-on: IPQ5424 hw1.0 AHB WLAN.WBE.1.6-01275-QCAHKSWPL_SILICONZ-1
>
> Signed-off-by: Saravanakumar Duraisamy <quic_saradura@quicinc.com>
> Signed-off-by: Raj Kumar Bhagat <raj.bhagat@oss.qualcomm.com>
> Reviewed-by: Baochen Qiang <baochen.qiang@oss.qualcomm.com>
> ---
> drivers/net/wireless/ath/ath12k/wifi7/hal.c | 2 +-
> drivers/net/wireless/ath/ath12k/wifi7/hal.h | 3 +
> .../net/wireless/ath/ath12k/wifi7/hal_qcn9274.c | 88 ++++++++++++++++++++++
> .../net/wireless/ath/ath12k/wifi7/hal_qcn9274.h | 1 +
> 4 files changed, 93 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath12k/wifi7/hal.c b/drivers/net/wireless/ath/ath12k/wifi7/hal.c
> index c2cc99a83f09..a0a1902fb491 100644
> --- a/drivers/net/wireless/ath/ath12k/wifi7/hal.c
> +++ b/drivers/net/wireless/ath/ath12k/wifi7/hal.c
> @@ -55,7 +55,7 @@ static const struct ath12k_hw_version_map ath12k_wifi7_hw_ver_map[] = {
> .hal_desc_sz = sizeof(struct hal_rx_desc_qcn9274_compact),
> .tcl_to_wbm_rbm_map = ath12k_hal_tcl_to_wbm_rbm_map_qcn9274,
> .hal_params = &ath12k_hw_hal_params_ipq5332,
> - .hw_regs = NULL,
> + .hw_regs = &ipq5424_regs,
> },
> };
>
> diff --git a/drivers/net/wireless/ath/ath12k/wifi7/hal.h b/drivers/net/wireless/ath/ath12k/wifi7/hal.h
> index 9337225a5253..3d9386198893 100644
> --- a/drivers/net/wireless/ath/ath12k/wifi7/hal.h
> +++ b/drivers/net/wireless/ath/ath12k/wifi7/hal.h
> @@ -364,6 +364,9 @@
> #define HAL_IPQ5332_CE_WFSS_REG_BASE 0x740000
> #define HAL_IPQ5332_CE_SIZE 0x100000
>
> +#define HAL_IPQ5424_CE_WFSS_REG_BASE 0x200000
> +#define HAL_IPQ5424_CE_SIZE 0x100000
> +
> #define HAL_RX_MAX_BA_WINDOW 256
>
> #define HAL_DEFAULT_BE_BK_VI_REO_TIMEOUT_USEC (100 * 1000)
> diff --git a/drivers/net/wireless/ath/ath12k/wifi7/hal_qcn9274.c b/drivers/net/wireless/ath/ath12k/wifi7/hal_qcn9274.c
> index 41c918eb1767..ba9ce1e718e8 100644
> --- a/drivers/net/wireless/ath/ath12k/wifi7/hal_qcn9274.c
> +++ b/drivers/net/wireless/ath/ath12k/wifi7/hal_qcn9274.c
> @@ -484,6 +484,94 @@ const struct ath12k_hw_regs ipq5332_regs = {
> HAL_IPQ5332_CE_WFSS_REG_BASE,
> };
>
> +const struct ath12k_hw_regs ipq5424_regs = {
> + /* SW2TCL(x) R0 ring configuration address */
> + .tcl1_ring_id = 0x00000918,
> + .tcl1_ring_misc = 0x00000920,
> + .tcl1_ring_tp_addr_lsb = 0x0000092c,
> + .tcl1_ring_tp_addr_msb = 0x00000930,
> + .tcl1_ring_consumer_int_setup_ix0 = 0x00000940,
> + .tcl1_ring_consumer_int_setup_ix1 = 0x00000944,
> + .tcl1_ring_msi1_base_lsb = 0x00000958,
> + .tcl1_ring_msi1_base_msb = 0x0000095c,
> + .tcl1_ring_base_lsb = 0x00000910,
> + .tcl1_ring_base_msb = 0x00000914,
> + .tcl1_ring_msi1_data = 0x00000960,
> + .tcl2_ring_base_lsb = 0x00000988,
> + .tcl_ring_base_lsb = 0x00000b68,
> +
> + /* TCL STATUS ring address */
> + .tcl_status_ring_base_lsb = 0x00000d48,
> +
> + /* REO DEST ring address */
> + .reo2_ring_base = 0x00000578,
> + .reo1_misc_ctrl_addr = 0x00000b9c,
> + .reo1_sw_cookie_cfg0 = 0x0000006c,
> + .reo1_sw_cookie_cfg1 = 0x00000070,
> + .reo1_qdesc_lut_base0 = 0x00000074,
> + .reo1_qdesc_lut_base1 = 0x00000078,
> + .reo1_ring_base_lsb = 0x00000500,
> + .reo1_ring_base_msb = 0x00000504,
> + .reo1_ring_id = 0x00000508,
> + .reo1_ring_misc = 0x00000510,
> + .reo1_ring_hp_addr_lsb = 0x00000514,
> + .reo1_ring_hp_addr_msb = 0x00000518,
> + .reo1_ring_producer_int_setup = 0x00000524,
> + .reo1_ring_msi1_base_lsb = 0x00000548,
> + .reo1_ring_msi1_base_msb = 0x0000054C,
> + .reo1_ring_msi1_data = 0x00000550,
> + .reo1_aging_thres_ix0 = 0x00000B28,
> + .reo1_aging_thres_ix1 = 0x00000B2C,
> + .reo1_aging_thres_ix2 = 0x00000B30,
> + .reo1_aging_thres_ix3 = 0x00000B34,
> +
> + /* REO Exception ring address */
> + .reo2_sw0_ring_base = 0x000008c0,
> +
> + /* REO Reinject ring address */
> + .sw2reo_ring_base = 0x00000320,
> + .sw2reo1_ring_base = 0x00000398,
> +
> + /* REO cmd ring address */
> + .reo_cmd_ring_base = 0x000002A8,
> +
> + /* REO status ring address */
> + .reo_status_ring_base = 0x00000aa0,
> +
> + /* WBM idle link ring address */
> + .wbm_idle_ring_base_lsb = 0x00000d3c,
> + .wbm_idle_ring_misc_addr = 0x00000d4c,
> + .wbm_r0_idle_list_cntl_addr = 0x00000240,
> + .wbm_r0_idle_list_size_addr = 0x00000244,
> + .wbm_scattered_ring_base_lsb = 0x00000250,
> + .wbm_scattered_ring_base_msb = 0x00000254,
> + .wbm_scattered_desc_head_info_ix0 = 0x00000260,
> + .wbm_scattered_desc_head_info_ix1 = 0x00000264,
> + .wbm_scattered_desc_tail_info_ix0 = 0x00000270,
> + .wbm_scattered_desc_tail_info_ix1 = 0x00000274,
> + .wbm_scattered_desc_ptr_hp_addr = 0x0000027c,
> +
> + /* SW2WBM release ring address */
> + .wbm_sw_release_ring_base_lsb = 0x0000037c,
> +
> + /* WBM2SW release ring address */
> + .wbm0_release_ring_base_lsb = 0x00000e08,
> + .wbm1_release_ring_base_lsb = 0x00000e80,
> +
> + /* PPE release ring address */
> + .ppe_rel_ring_base = 0x0000046c,
> +
> + /* CE address */
> + .umac_ce0_src_reg_base = 0x00200000 -
> + HAL_IPQ5424_CE_WFSS_REG_BASE,
> + .umac_ce0_dest_reg_base = 0x00201000 -
> + HAL_IPQ5424_CE_WFSS_REG_BASE,
> + .umac_ce1_src_reg_base = 0x00202000 -
> + HAL_IPQ5424_CE_WFSS_REG_BASE,
> + .umac_ce1_dest_reg_base = 0x00203000 -
> + HAL_IPQ5424_CE_WFSS_REG_BASE,
> +};
> +
> static inline
> bool ath12k_hal_rx_desc_get_first_msdu_qcn9274(struct hal_rx_desc *desc)
> {
> diff --git a/drivers/net/wireless/ath/ath12k/wifi7/hal_qcn9274.h b/drivers/net/wireless/ath/ath12k/wifi7/hal_qcn9274.h
> index 08c0a0469474..03cf3792d523 100644
> --- a/drivers/net/wireless/ath/ath12k/wifi7/hal_qcn9274.h
> +++ b/drivers/net/wireless/ath/ath12k/wifi7/hal_qcn9274.h
> @@ -17,6 +17,7 @@ extern const struct hal_ops hal_qcn9274_ops;
> extern const struct ath12k_hw_regs qcn9274_v1_regs;
> extern const struct ath12k_hw_regs qcn9274_v2_regs;
> extern const struct ath12k_hw_regs ipq5332_regs;
> +extern const struct ath12k_hw_regs ipq5424_regs;
> extern const struct ath12k_hal_tcl_to_wbm_rbm_map
> ath12k_hal_tcl_to_wbm_rbm_map_qcn9274[DP_TCL_NUM_RING_MAX];
> extern const struct ath12k_hw_hal_params ath12k_hw_hal_params_qcn9274;
>
Reviewed-by: Rameshkumar Sundaram <rameshkumar.sundaram@oss.qualcomm.com>
next prev parent reply other threads:[~2026-04-07 16:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-07 5:26 [PATCH ath-next v5 0/6] wifi: ath12k: Enable IPQ5424 AHB WiFi device Raj Kumar Bhagat
2026-04-07 5:26 ` [PATCH ath-next v5 1/6] dt-bindings: net: wireless: add ath12k wifi device IPQ5424 Raj Kumar Bhagat
2026-04-07 5:26 ` [PATCH ath-next v5 2/6] wifi: ath12k: Add ath12k_hw_params for IPQ5424 Raj Kumar Bhagat
2026-04-07 16:20 ` Rameshkumar Sundaram
2026-04-07 5:26 ` [PATCH ath-next v5 3/6] wifi: ath12k: add ath12k_hw_version_map entry " Raj Kumar Bhagat
2026-04-07 16:21 ` Rameshkumar Sundaram
2026-04-07 5:26 ` [PATCH ath-next v5 4/6] wifi: ath12k: add ath12k_hw_regs " Raj Kumar Bhagat
2026-04-07 16:22 ` Rameshkumar Sundaram [this message]
2026-04-07 5:26 ` [PATCH ath-next v5 5/6] wifi: ath12k: Add CE remap hardware parameters " Raj Kumar Bhagat
2026-04-07 16:23 ` Rameshkumar Sundaram
2026-04-07 5:26 ` [PATCH ath-next v5 6/6] wifi: ath12k: Enable IPQ5424 WiFi device support Raj Kumar Bhagat
2026-04-07 16:24 ` Rameshkumar Sundaram
2026-04-08 0:50 ` [PATCH ath-next v5 0/6] wifi: ath12k: Enable IPQ5424 AHB WiFi device Jeff Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be871892-cb95-4316-bdf4-4609f1c46d0b@oss.qualcomm.com \
--to=rameshkumar.sundaram@oss.qualcomm.com \
--cc=ath12k@lists.infradead.org \
--cc=baochen.qiang@oss.qualcomm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jjohnson@kernel.org \
--cc=johannes@sipsolutions.net \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_saradura@quicinc.com \
--cc=raj.bhagat@oss.qualcomm.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox