From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B23E7EB64DA for ; Fri, 30 Jun 2023 10:02:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232915AbjF3KCP (ORCPT ); Fri, 30 Jun 2023 06:02:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50928 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232974AbjF3KBs (ORCPT ); Fri, 30 Jun 2023 06:01:48 -0400 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7DCAD1FCB for ; Fri, 30 Jun 2023 03:01:47 -0700 (PDT) Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 35U8rA2O009671; Fri, 30 Jun 2023 09:32:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=PK24KpSvL0d1KNy5acQjsM972gYJThX7jVCYosHgcX8=; b=Svdl01UpCRa7sW4Kd8D/iu53nOScPxSqY/knNpQS3dmhlDBefVebiH/66g3A+BZygG2q XP2O6OVnASOBimnzUt8WFiwHr5KaQy+2wAzEir4fxz+KFx3Ta1k9NE61H2c9RpIYwoie gbVm9ARa2xTn95oooGCTBRqvHoqilvB/DycVj/gOpanBwN3rgK44VV9w56WDW83vYTcf ZCWkEMumk3oxzwtnVqTztO2bGDyopOIssH5kwk4251YdmHE+JylyC3fNPvUtxxMwypHl x2cPAceEJtqX1P0XHPmr1O6W1viOkBrreNIDYUSCVHvn6F9X6ljebf6ZiSDtkQLHFmqu pw== Received: from nalasppmta04.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3rh4y6auqf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 30 Jun 2023 09:32:15 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 35U9WEW1023000 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 30 Jun 2023 09:32:14 GMT Received: from [10.231.195.204] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.7; Fri, 30 Jun 2023 02:32:13 -0700 Message-ID: Date: Fri, 30 Jun 2023 17:32:09 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 10/27] wifi: mac80211: isolate driver from inactive links Content-Language: en-US To: Johannes Berg , CC: References: <20220902141259.377789-1-johannes@sipsolutions.net> <20220902161143.5ce3dad3be7c.I92e9f7a6c120cd4a3631baf486ad8b6aafcd796f@changeid> <5d82e564-86bf-c26b-077a-d0bc14e2d3c3@quicinc.com> <74f3eb848326607b15336c31a02bdd861ccafb47.camel@sipsolutions.net> <113761966918b2f390d3c9304307b42a0b4a829b.camel@sipsolutions.net> <76863dec-1b2f-b933-7c5e-21c732de4bc6@quicinc.com> <2cc79101249548f2a92c14af6aff6121143907d6.camel@sipsolutions.net> <1c26c205-0240-7670-117d-02a7af068724@quicinc.com> <6f8db032286923845202c7d658f1d39db79a758c.camel@sipsolutions.net> From: Wen Gong In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: EjeUSHDCPmsfhSyh1c7o2LQPVaf5FISr X-Proofpoint-ORIG-GUID: EjeUSHDCPmsfhSyh1c7o2LQPVaf5FISr X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-06-30_05,2023-06-30_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 spamscore=0 malwarescore=0 bulkscore=0 clxscore=1015 lowpriorityscore=0 phishscore=0 impostorscore=0 mlxlogscore=645 suspectscore=0 mlxscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306300079 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 6/15/2023 3:56 PM, Johannes Berg wrote: > On Thu, 2023-06-15 at 10:26 +0800, Wen Gong wrote: >> On 6/15/2023 2:32 AM, Johannes Berg wrote: >>> On Wed, 2023-05-24 at 15:41 +0800, Wen Gong wrote: >>> ... >> Could you tell detail about how the BSS_CHANGE flag works?😁 > The work isn't complete yet, but basically it just calls the callback > whenever the valid_links changed, say by link-reconfiguration. > > johannes I guess the link-reconfiguration you said is for station, it means station will do corresponding link-reconfiguration after receive link reconfiguration indication(e.g. Reconfiguration Multi-Link element) from MLO AP, right? I guess you will add enum BSS_CHANGED_xxx(e.g. BSS_CHANGED_LINK_RECONFIG), and call vif_cfg_changed of struct ieee80211_ops for link-reconfiguration, right? And do you will implement both remove link and add link of station? For add link, it should calculate the new key of the new link("35.3.6.4 ML reconfiguration to the ML setup" of IEEE P802.11be™/D3.2).