From: Felix Fietkau <nbd@nbd.name>
To: Yi-Chia Hsieh <yi-chia.hsieh@mediatek.com>,
Johannes Berg <johannes.berg@intel.com>
Cc: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>,
Ryder Lee <ryder.lee@mediatek.com>,
Shayne Chen <shayne.chen@mediatek.com>,
Evelyn Tsai <evelyn.tsai@mediatek.com>,
Money Wang <money.wang@mediatek.com>,
Peter Chiu <chui-hao.chiu@mediatek.com>,
Benjamin Lin <benjamin-jw.lin@mediatek.com>,
linux-wireless@vger.kernel.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v2 2/4] wifi: mt76: mt7996: Add mcu commands for getting sta tx statistic
Date: Mon, 18 Sep 2023 12:14:50 +0200 [thread overview]
Message-ID: <c00c641b-f5b3-4bca-8d41-4e048b09a794@nbd.name> (raw)
In-Reply-To: <ef87bde6ef590ce39515a683e33313d1434b3064.1693549298.git.yi-chia.hsieh@mediatek.com>
On 01.09.23 08:30, Yi-Chia Hsieh wrote:
> Per peer Tx/Rx statistic can only be obtained by querying WM when WED is
> on. This patch switches to periodic event reporting in the case of WED
> being enabled.
>
> Signed-off-by: Yi-Chia Hsieh <yi-chia.hsieh@mediatek.com>
> ---
> v2: split series
> ---
> .../wireless/mediatek/mt76/mt76_connac_mcu.h | 15 ++++
> .../net/wireless/mediatek/mt76/mt7996/mac.c | 5 ++
> .../net/wireless/mediatek/mt76/mt7996/main.c | 15 ++++
> .../net/wireless/mediatek/mt76/mt7996/mcu.c | 68 +++++++++++++++++++
> .../net/wireless/mediatek/mt76/mt7996/mcu.h | 26 +++++++
> .../wireless/mediatek/mt76/mt7996/mt7996.h | 1 +
> 6 files changed, 130 insertions(+)
>
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7996/mcu.h b/drivers/net/wireless/mediatek/mt76/mt7996/mcu.h
> index 078f82858621..5aece2046a9d 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7996/mcu.h
> +++ b/drivers/net/wireless/mediatek/mt76/mt7996/mcu.h
> @@ -153,6 +153,32 @@ struct mt7996_mcu_mib {
> __le64 data;
> } __packed;
>
> +struct mt7996_mcu_all_sta_info_event {
> + u8 rsv[4];
> + __le16 tag;
> + __le16 len;
> + u8 more;
> + u8 rsv2;
> + __le16 sta_num;
> + u8 rsv3[2];
> +
> + union {
> + struct {
> + __le16 wlan_idx;
> + u8 rsv[2];
> + __le32 tx_bytes[IEEE80211_NUM_ACS];
> + __le32 rx_bytes[IEEE80211_NUM_ACS];
> + } adm_stat[];
> +
> + struct {
> + __le16 wlan_idx;
> + u8 rsv[2];
> + __le32 tx_msdu_cnt;
> + __le32 rx_msdu_cnt;
> + } msdu_cnt[];
> + };
> +} __packed;
With this, I'm getting compiler errors like this one:
mcu.h:171:19: error: flexible array member in union
- Felix
next prev parent reply other threads:[~2023-09-18 10:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-01 6:30 [PATCH v2 1/4] wifi: mt76: mt7996: get tx_retries and tx_failed from txfree Yi-Chia Hsieh
2023-09-01 6:30 ` [PATCH v2 2/4] wifi: mt76: mt7996: Add mcu commands for getting sta tx statistic Yi-Chia Hsieh
2023-09-18 10:14 ` Felix Fietkau [this message]
2023-09-01 6:30 ` [PATCH v2 3/4] wifi: mt76: mt7996: enable PPDU-TxS to host Yi-Chia Hsieh
2023-09-01 6:30 ` [PATCH v2 4/4] wifi: mt76: mt7996: remove periodic MPDU TXS request Yi-Chia Hsieh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c00c641b-f5b3-4bca-8d41-4e048b09a794@nbd.name \
--to=nbd@nbd.name \
--cc=benjamin-jw.lin@mediatek.com \
--cc=chui-hao.chiu@mediatek.com \
--cc=evelyn.tsai@mediatek.com \
--cc=johannes.berg@intel.com \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=money.wang@mediatek.com \
--cc=ryder.lee@mediatek.com \
--cc=shayne.chen@mediatek.com \
--cc=yi-chia.hsieh@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox