From: Xianwei Zhao <xianwei.zhao@amlogic.com>
To: Ronald Claveau <linux-kernel-dev@aliel.fr>,
Neil Armstrong <neil.armstrong@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Johannes Berg <johannes@sipsolutions.net>,
van Spriel <arend@broadcom.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH v3 2/9] dt-bindings: mmc: amlogic: Add compatible for T7 mmc
Date: Wed, 25 Mar 2026 10:38:37 +0800 [thread overview]
Message-ID: <c01c4e7e-1c0c-4bbf-b126-831160c8e32b@amlogic.com> (raw)
In-Reply-To: <20260323-add-emmc-t7-vim4-v3-2-5159d90a984c@aliel.fr>
Hi Ronald,
On 2026/3/23 17:55, Ronald Claveau wrote:
> Add amlogic,t7-mmc compatible string, falling back to amlogic,meson-axg-mmc
> as the T7 MMC controller is compatible with the AXG implementation.
>
> Signed-off-by: Ronald Claveau<linux-kernel-dev@aliel.fr>
> ---
> Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml | 5
> ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git
> a/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml
> b/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml
> index 57646575a13f8..40dccf9715781 100644
> --- a/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml
> +++ b/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml
> @@ -19,7 +19,10 @@ allOf:
> properties:
> compatible:
> oneOf:
> - - const: amlogic,meson-axg-mmc
> + - items:
> + - enum:
> + - amlogic,t7-mmc
> + - const: amlogic,meson-axg-mmc
It seems that break API here.
One item should be added here instead of being replaced.
> - items:
> - const: amlogic,meson-gx-mmc
> - const: amlogic,meson-gxbb-mmc
>
> --
> 2.49.0
next prev parent reply other threads:[~2026-03-25 2:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 9:55 [PATCH v3 0/9] arm64: dts: amlogic: Add MMC/SD/SDIO support for Khadas VIM4 (Amlogic T7) Ronald Claveau
2026-03-23 9:55 ` [PATCH v3 1/9] arm64: dts: amlogic: t7: Add eMMC, SD card and SDIO pinctrl nodes Ronald Claveau
2026-03-25 2:48 ` Xianwei Zhao
2026-03-25 8:40 ` Ronald Claveau
2026-03-23 9:55 ` [PATCH v3 2/9] dt-bindings: mmc: amlogic: Add compatible for T7 mmc Ronald Claveau
2026-03-23 19:38 ` Conor Dooley
2026-03-24 15:03 ` Ulf Hansson
2026-03-25 2:38 ` Xianwei Zhao [this message]
2026-03-25 8:45 ` Ronald Claveau
2026-03-23 9:55 ` [PATCH v3 3/9] arm64: dts: amlogic: t7: Add MMC controller nodes Ronald Claveau
2026-03-23 9:55 ` [PATCH v3 4/9] arm64: dts: amlogic: t7: Add PWM pinctrl nodes Ronald Claveau
2026-03-23 9:55 ` [PATCH v3 5/9] arm64: dts: amlogic: t7: Add PWM controller nodes Ronald Claveau
2026-03-23 9:55 ` [PATCH v3 6/9] arm64: dts: amlogic: t7: khadas-vim4: Add power regulators Ronald Claveau
2026-03-23 9:55 ` [PATCH v3 7/9] arm64: dts: amlogic: t7: khadas-vim4: Add SDIO power sequence and WiFi clock Ronald Claveau
2026-03-23 9:55 ` [PATCH v3 8/9] dt-bindings: net: wireless: brcm: Add compatible for bcm43752 Ronald Claveau
2026-03-23 19:37 ` Conor Dooley
2026-03-23 9:55 ` [PATCH v3 9/9] arm64: dts: amlogic: t7: khadas-vim4: Add MMC nodes Ronald Claveau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c01c4e7e-1c0c-4bbf-b126-831160c8e32b@amlogic.com \
--to=xianwei.zhao@amlogic.com \
--cc=arend@broadcom.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=johannes@sipsolutions.net \
--cc=khilman@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel-dev@aliel.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=robh@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox