Re: [PATCH wireless-next v2] wifi: mac80211: Guard FILS discovery and unsolicited broadcast probe response

[Manish Dharanenthiran <manish.dharanenthiran@oss.qualcomm.com>]

On 9/21/2026 2:27 PM, Johannes Berg wrote:
> On Fri, 2026-09-18 at 12:47 +0530, Manish Dharanenthiran wrote:
>>
>> Currently in user-space there is no restriction on sending this for
>> non-transmitting BSS, thus it may send these for those BSSs as well.
>> However the driver will use the config only for transmitting BSS and
>> ignore for non-transmitting BSS. Returning an error here, even if
>> user-space sets these, could be fatal because failing start_ap or
>> update_ap operation would result in failure of bringing up those BSSs.
>> Thus, ignore the config for non-transmitting BSS silently.
> 
> And honestly, it really _should_ be fatal since it really is a wront
> configuration, so that text isn't really that useful, nor the comments:
> 
>> +	/*
>> +	 * Only transmitting BSS should set this config, ignore this config for
>> +	 * non-transmitting BSS silently even if user-space sets it, as
>> +	 * returning error would result in failure of bringing up of those BSSs.
>> +	 */
>> +	if (!params->update || link_conf->nontransmitted)
> 
> Please state that currently it actually _is_ (erroneously) being set by
> hostapd and we need to keep it working.
> 
> johannes

Understood!, will modify the text and the comments in the next version.

-- 
- Manish D