From: Arend Van Spriel <arend.vanspriel@broadcom.com>
To: Johannes Berg <johannes@sipsolutions.net>, Jouni Malinen <j@w1.fi>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [RFC] cfg80211: add control port state to struct cfg80211_connect_resp_params
Date: Wed, 26 Apr 2017 20:46:53 +0200 [thread overview]
Message-ID: <c0b5817a-c4fa-8f7c-2632-cf22aa09d71b@broadcom.com> (raw)
In-Reply-To: <1493191249.2464.6.camel@sipsolutions.net>
On 26-4-2017 9:20, Johannes Berg wrote:
> On Tue, 2017-04-25 at 20:56 +0200, Arend Van Spriel wrote:
>>
>> You might, but not about this ;-) The other approach I had in mind is
>> to only pass the flag for drivers with 4-way-hs support. In that case
>> wpa_supp also has to check that to determine whether the flag should
>> be taken into account. Assuming the driver supporting 4-way-hs can
>> provide the port state info. Otherwise, a new ext_feature flag would
>> be needed.
>
> I think it's reasonable to assume 4-way-HS offload drivers can support
> it.
I tested the 4-way-hs (both Personal and 802.1X) with boolean parameter
similar to what is proposed in the patch for roaming "cfg80211/nl80211:
add authorized flag to roaming event" and it works fine. So I can extend
it for use in connect result. Just had one issue regarding the type, ie.
flag vs. u8 because of how things are done in wpa_supplicant supporting
QCA roam+auth vendor-specific event.
Regards,
Arend
next prev parent reply other threads:[~2017-04-26 18:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-21 21:01 [RFC] cfg80211: add control port state to struct cfg80211_connect_resp_params Arend van Spriel
2017-04-25 14:40 ` Johannes Berg
2017-04-25 18:34 ` Arend Van Spriel
2017-04-25 18:36 ` Johannes Berg
2017-04-25 18:56 ` Arend Van Spriel
2017-04-26 7:20 ` Johannes Berg
2017-04-26 18:46 ` Arend Van Spriel [this message]
2017-04-28 12:02 ` Johannes Berg
2017-04-28 12:46 ` Arend Van Spriel
2017-04-28 12:53 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0b5817a-c4fa-8f7c-2632-cf22aa09d71b@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=j@w1.fi \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).