From: asinghal@codeaurora.org
To: Arend Van Spriel <arend.vanspriel@broadcom.com>
Cc: johannes@sipsolutions.net, jouni@codeaurora.org,
linux-wireless@vger.kernel.org, jjohnson@codeaurora.org,
rmanohar@codeaurora.org
Subject: Re: [PATCH] cfg80211: Convert 6 GHz channel frequency to channel number
Date: Fri, 30 Aug 2019 11:08:34 -0700 [thread overview]
Message-ID: <c0e98022ea9be0e9f2bb01c06b712bf0@codeaurora.org> (raw)
In-Reply-To: <eced13d4e91dee3f5ad82a2278ef7af5@codeaurora.org>
Correction in typo below:
On 2019-08-30 11:03, asinghal@codeaurora.org wrote:
> On 2019-08-30 03:45, Arend Van Spriel wrote:
>> On 8/30/2019 12:21 AM, Amar Singhal wrote:
>>> Enhance function ieee80211_frequency_to_channel by adding 6 GHz
>>> channels.
>>
>> This look very similar to what I submitted earlier:
>>
>> https://patchwork.kernel.org/patch/11073197/
>>
>> Regards,
>> Arend
> - else if (freq <= 45000) /* DMG band lower limit */
> + else if (freq < 5940)
> return (freq - 5000) / 5;
> + else if (freq <= 45000) /* DMG band lower limit */
> + /* see 802.11ax D4.1 27.3.22.2 */
> + return (freq - 5940) / 5;
>
> hi Arend,
> I see a small issue in your patch above; for frequency 5940,
> the channel number returned would be 0 which is an invalid channel. I
> guess 6 GHz center frequency numbers begin with 5945.
>
> rgds,
> Amar
prev parent reply other threads:[~2019-08-30 18:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-29 22:21 [PATCH] cfg80211: Convert 6 GHz channel frequency to channel number Amar Singhal
2019-08-30 10:32 ` Johannes Berg
2019-08-30 10:47 ` Arend Van Spriel
2019-08-30 10:48 ` Johannes Berg
2019-08-30 10:45 ` Arend Van Spriel
2019-08-30 18:03 ` asinghal
2019-08-30 18:08 ` asinghal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0e98022ea9be0e9f2bb01c06b712bf0@codeaurora.org \
--to=asinghal@codeaurora.org \
--cc=arend.vanspriel@broadcom.com \
--cc=jjohnson@codeaurora.org \
--cc=johannes@sipsolutions.net \
--cc=jouni@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rmanohar@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).