From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25ED2C77B70 for ; Mon, 17 Apr 2023 14:13:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230003AbjDQONe (ORCPT ); Mon, 17 Apr 2023 10:13:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38974 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229667AbjDQONd (ORCPT ); Mon, 17 Apr 2023 10:13:33 -0400 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B94705B80 for ; Mon, 17 Apr 2023 07:13:17 -0700 (PDT) Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 33H8tAwO006609; Mon, 17 Apr 2023 14:13:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=DyeTitlKMgOzR9t9oQYxL+nfdGjKJlvEuLfb5WCEeTU=; b=CrtM57uehS9t2yTXfvFPsp8zErQzICskPPPKLYg5yJdEM+y0iKVzCA7EzjmnW/XvebN5 clpwgeJjAtaSZ3Y3t+lG5PDk6vVbzdFcZrcVVPTuA6ftJbnSzEGTV+oYdhoJlUBwQ5qq dob5LCqy4QbQ9m4b1f8MLwohBnINMGaY0T9VYHo0D8LsHLzeKX+tdPTiQ4n9wIvtFpGD 0JaR+MEkVmjuKTESi1P8t08x5ZjRQ5t32bbDVFVbOAhWrlvZLaRyMVa0CnpwcZ9h2Beq WNm6LmzSV30S3B9s5NVY3P8o7NXA0gr3Ws05vSMImQuTC7rpd/22sviNqMo+jSyZSnII 8Q== Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3q12strq3e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 17 Apr 2023 14:13:12 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 33HEDBoG003380 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 17 Apr 2023 14:13:11 GMT Received: from [10.253.75.31] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.42; Mon, 17 Apr 2023 07:13:10 -0700 Message-ID: Date: Mon, 17 Apr 2023 22:13:07 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 10/27] wifi: mac80211: isolate driver from inactive links Content-Language: en-US To: Johannes Berg , CC: References: <20220902141259.377789-1-johannes@sipsolutions.net> <20220902161143.5ce3dad3be7c.I92e9f7a6c120cd4a3631baf486ad8b6aafcd796f@changeid> <5d82e564-86bf-c26b-077a-d0bc14e2d3c3@quicinc.com> <74f3eb848326607b15336c31a02bdd861ccafb47.camel@sipsolutions.net> From: Wen Gong In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: pTSaSkIa6DuUp8ovzv0h2PtlccDewtUp X-Proofpoint-ORIG-GUID: pTSaSkIa6DuUp8ovzv0h2PtlccDewtUp X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-04-17_09,2023-04-17_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=0 mlxscore=0 impostorscore=0 adultscore=0 bulkscore=0 mlxlogscore=878 phishscore=0 clxscore=1015 spamscore=0 malwarescore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2304170127 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 4/11/2023 3:38 PM, Johannes Berg wrote: > On Tue, 2023-04-04 at 11:28 +0800, Wen Gong wrote: >> May I also add a field such as "u16 active_links_count" in struct >> wiphy_iftype_ext_capab, >> and add logic in function ieee80211_set_vif_links_bitmaps() for station >> like this ?: >> if (active_links_count && hweight16(links) <= active_links_count) >>     then sdata->vif.active_links = links; >> > Also here, not sure it makes sense in cfg80211 level? > > Though I'm not sure what the idea here is at all - you can refuse to > link switch etc, what would you use this for? If I use ieee80211_set_active_links(), then I need add BSS_CHANGED_ASSOC and key for 2nd link in lower-driver. I would like to active all links while assoc, then BSS_CHANGED_ASSOC and key will auto set for the 2nd link to lower-driver from mac80211. > > Then again, we haven't really designed out all the link selection stuff, > do we want wpa_s to do it, driver to do it, etc.? Hence debugfs. So > depending on what end up doing there, we will obviously need to > advertise some level of link-concurrency to userspace. > > johannes