Re: [PATCH 4.12] brcmfmac: get rid of brcmf_txflowblock helper function

[Arend Van Spriel <arend.vanspriel@broadcom.com>]

On 28-2-2017 11:00, Rafał Miłecki wrote:
> On 28 February 2017 at 10:50, Arend Van Spriel
> <arend.vanspriel@broadcom.com> wrote:
>> On 27-2-2017 13:06, Rafał Miłecki wrote:
>>> From: Rafał Miłecki <rafal@milecki.pl>
>>>
>>> This helper function is pretty trivial and we can easily do without it.
>>> What's important though it's one of FWS (Firmware Signalling)
>>> dependencies in core.c. The plan is to make FWS required by BCDC only so
>>> we don't have to use/compile it when using msgbuf.
>>
>> This is the same discussion as before. Our driver design really wants to
>> keep bus-specific code separated from common code. Adding more and more
>> include statements is breaking that design. Whether or not that
>> resembles the way other drivers do it is not really a consideration. So
>> I would rather like to see patches that improve that separation.
>>
>> I will see if I can publish the design summary on our wiki page.
> 
> You may not like this solution, but if so, please suggest another one.
> Then we can discuss two of them & find a final one.
> 
> As you see I'm trying to drop fws dependency from core.c. It's what
> was very roughly discussed in:
> brcmfmac: initialize fws(ignal) for BCDC protocol only
> https://patchwork.kernel.org/patch/9349301/
> 
> My guess if you have another patch for this, but since you didn't
> manage to release it since September, I'd really like to move things
> forward somehow.

Franky has taken it on his shoulders, but it seems to have slipped under
the rug. Maybe he can chime in.

Regards,
Arend