Re: [PATCH] wifi: brcmfmac: cfg80211: Use WSEC to set SAE password

[Arend van Spriel <arend.vanspriel@broadcom.com>]

[-- Attachment #1: Type: text/plain, Size: 2168 bytes --]

On 12/19/2023 12:01 PM, Hector Martin wrote:
> 
> 
> On 2023/12/19 17:52, Arend Van Spriel wrote:
>> On December 17, 2023 12:25:23 PM Kalle Valo <kvalo@kernel.org> wrote:
>>
>>> Hector Martin <marcan@marcan.st> wrote:
>>>
>>>> Using the WSEC command instead of sae_password seems to be the supported
>>>> mechanism on newer firmware, and also how the brcmdhd driver does it.
>>>>
>>>> According to user reports [1], the sae_password codepath doesn't actually
>>>> work on machines with Cypress chips anyway, so no harm in removing it.
>>>>
>>>> This makes WPA3 work with iwd, or with wpa_supplicant pending a support
>>>> patchset [2].
>>>>
>>>> [1] https://rachelbythebay.com/w/2023/11/06/wpa3/
>>>> [2] http://lists.infradead.org/pipermail/hostap/2023-July/041653.html
>>>>
>>>> Signed-off-by: Hector Martin <marcan@marcan.st>
>>>> Reviewed-by: Neal Gompa <neal@gompa.dev>
>>>
>>> Arend, what do you think?
>>>
>>> We recently talked about people testing brcmfmac patches, has anyone else
>>> tested this?
>>
>> Not sure I already replied so maybe I am repeating myself. I would prefer
>> to keep the Cypress sae_password path as well although it reportedly does
>> not work. The vendor support in the driver can be used to accommodate for
>> that. The other option would be to have people with Cypress chipset test
>> this patch. If that works for both we can consider dropping the
>> sae_password path.
>>
>> Regards,
>> Arend
> 
> So, if nobody from Cypress chimes in ever, and nobody cares nor tests
> Cypress chipsets, are we keeping any and all existing Cypress code-paths
> as bitrotting code forever and adding gratuitous conditionals every time
> any functionality needs to change "just in case it breaks Cypress" even
> though it has been tested compatible on Broadcom chipsets/firmware?
> 
> Because that's not sustainable long term.

You should look into WEXT just for the fun of it. If it were up to me 
and a bunch of other people that would have been gone decades ago. Maybe 
a bad example if the sae_password is indeed not working, but the Cypress 
chipset is used in RPi3 and RPi4 so there must be a couple of users.

Regards,
Arend

Regards,
Arend

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4219 bytes --]