From: Joe Perches <joe@perches.com>
To: John Crispin <john@phrozen.org>,
Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org,
Shashidhar Lakkavalli <slakkavalli@datto.com>
Subject: Re: [PATCH V2] iw: print HE capabilities
Date: Thu, 06 Jun 2019 19:11:53 -0700 [thread overview]
Message-ID: <c3f982260cdf0749201f5535bf0f3bf9f6bfa7ba.camel@perches.com> (raw)
In-Reply-To: <20190528065828.25356-1-john@phrozen.org>
On Tue, 2019-05-28 at 08:58 +0200, John Crispin wrote:
> Print the HE MAC/PHY capabilities and MCS/NSS sets.
trivia:
> diff --git a/util.c b/util.c
[]
> +void print_he_info(struct nlattr *nl_iftype)
> +{
> + struct nlattr *tb[NL80211_BAND_IFTYPE_ATTR_MAX + 1];
> + struct nlattr *tb_flags[NL80211_IFTYPE_MAX + 1];
> + char *iftypes[NUM_NL80211_IFTYPES] = {
> + "Unspec", "Adhoc", "Station", "AP", "AP/VLAN", "WDS", "Monitor",
> + "Mesh", "P2P/Client", "P2P/Go", "P2P/Device", "OCB", "NAN",
> + };
Should probably be
const char * const iftypes[...]
next prev parent reply other threads:[~2019-06-07 2:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-28 6:58 [PATCH V2] iw: print HE capabilities John Crispin
2019-05-28 7:02 ` Sven Eckelmann
2019-05-28 7:03 ` John Crispin
2019-06-07 2:11 ` Joe Perches [this message]
2019-06-07 7:22 ` Arend Van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3f982260cdf0749201f5535bf0f3bf9f6bfa7ba.camel@perches.com \
--to=joe@perches.com \
--cc=johannes@sipsolutions.net \
--cc=john@phrozen.org \
--cc=linux-wireless@vger.kernel.org \
--cc=slakkavalli@datto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox