Re: [PATCH v2 1/6] wifi: mt76: mt7925: load the appropriate CLC data based on hardware type

["Mingyen Hsieh (謝明諺)" <Mingyen.Hsieh@mediatek.com>]

On Tue, 2025-03-04 at 09:06 +0000, Ping-Ke Shih wrote:
> 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> Mingyen Hsieh <mingyen.hsieh@mediatek.com> wrote:
> 
> [...]
> 
> > +       struct evt {
> > +               u8 rsv[4];
> > +
> > +               __le16 tag;
> > +               __le16 len;
> > +
> > +               __le32 ver;
> > +               __le32 addr;
> > +               __le32 valid;
> > +               __le32 size;
> > +               __le32 magic_num;
> > +               __le32 type;
> > +               __le32 rsv1[4];
> > +               u8 data[32];
> > +       } __packed * res;
> 
> nit: no need space between * and res, i.e. "__packed *res".
> 
Hi Ping-Ke,

I also think this is better, but this was suggested to me by
script/checkpatch.pl.

I will send v4 for this.

> > +       struct sk_buff *skb;
> > +       int ret;
> > +
> > +       ret = mt76_mcu_send_and_get_msg(&dev->mt76,
> > MCU_WM_UNI_CMD_QUERY(EFUSE_CTRL),
> > +                                       &req, sizeof(req), true,
> > &skb);
> > +       if (ret)
> > +               return ret;
> > +
> > +       res = (struct evt *)skb->data;
> > +       *val = res->data[offset % MT7925_EEPROM_BLOCK_SIZE];
> > +
> > +       dev_kfree_skb(skb);
> > +
> > +       return 0;
> > +}
> > +
> >  static int mt7925_load_clc(struct mt792x_dev *dev, const char
> > *fw_name)
> >  {
> >         const struct mt76_connac2_fw_trailer *hdr;
> > @@ -809,12 +857,19 @@ static int mt7925_load_clc(struct mt792x_dev
> > *dev, const char *fw_name)
> >         struct mt792x_phy *phy = &dev->phy;
> >         const struct firmware *fw;
> >         int ret, i, len, offset = 0;
> > -       u8 *clc_base = NULL;
> > +       u8 *clc_base = NULL, hw_encap = 0;
> 
> not sure if mt76 declare local variables in reverse X'mas tree order?
> 
>