From: Ping-Ke Shih <pkshih@realtek.com>
To: "Colin King (gmail)" <colin.i.king@gmail.com>,
Kalle Valo <kvalo@kernel.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc: "kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH][next] wifi: rtw89: mac: Fix spelling mistakes "notfify" -> "notify"
Date: Mon, 25 Dec 2023 00:19:10 +0000 [thread overview]
Message-ID: <c43fe18df3cb488e9a3bdf38221e0a1b@realtek.com> (raw)
In-Reply-To: <75cd2090-857e-4082-bbc1-e3726235bda1@gmail.com>
> -----Original Message-----
> From: Colin King (gmail) <colin.i.king@gmail.com>
> Sent: Friday, December 22, 2023 8:09 PM
> To: Ping-Ke Shih <pkshih@realtek.com>; Kalle Valo <kvalo@kernel.org>; linux-wireless@vger.kernel.org
> Cc: kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH][next] wifi: rtw89: mac: Fix spelling mistakes "notfify" -> "notify"
>
> On 22/12/2023 00:19, Ping-Ke Shih wrote:
> >
> >
> >> -----Original Message-----
> >> From: Colin Ian King <colin.i.king@gmail.com>
> >> Sent: Wednesday, December 20, 2023 10:19 PM
> >> To: Ping-Ke Shih <pkshih@realtek.com>; Kalle Valo <kvalo@kernel.org>; linux-wireless@vger.kernel.org
> >> Cc: kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org
> >> Subject: [PATCH][next] wifi: rtw89: mac: Fix spelling mistakes "notfify" -> "notify"
> >>
> >> There are two spelling mistakes in rtw89_err error messages. Fix these
> >> and also add space between [ERR] and message text.
> >>
> >> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> >
> > Acked-by: Ping-Ke Shih <pkshih@realtek.com>
> >
> > Thanks for the correctness. Could I know the tool you used to find out these
> > typo?
>
> Sure,
>
> https://github.com/ColinIanKing/kernelscan
>
> It needs the american dictionary, installed in /usr/share/dict e.g.
> apt-get install wamerican
>
> and then spellcheck with:
>
> ./kernelscan -k path-to-code-you-want-to-scan
Thanks for the tool. :-)
I will try to scan my driver before sending out patches.
Ping-Ke
next prev parent reply other threads:[~2023-12-25 0:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-20 14:18 [PATCH][next] wifi: rtw89: mac: Fix spelling mistakes "notfify" -> "notify" Colin Ian King
2023-12-22 0:19 ` Ping-Ke Shih
2023-12-22 12:08 ` Colin King (gmail)
2023-12-25 0:19 ` Ping-Ke Shih [this message]
2024-01-10 14:51 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c43fe18df3cb488e9a3bdf38221e0a1b@realtek.com \
--to=pkshih@realtek.com \
--cc=colin.i.king@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox