From: Ping-Ke Shih <pkshih@realtek.com>
To: Arsenii Pashchenko <ulijg308@gmail.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 2/4] wifi: rtw88: rtw8822c: use sign_extend32 for DAC IQ validation
Date: Fri, 14 Aug 2026 08:03:55 +0000 [thread overview]
Message-ID: <c469acfcbf29407ebf04ad921339aeea@realtek.com> (raw)
In-Reply-To: <9be26fe7c6814b17baf2bb08fbfff6eb@realtek.com>
> > temp = rtw_read32_mask(rtwdev, 0x2dbc, 0x3fffff);
> > - iv[DACK_SN_8822C - 1] = (s32)((temp & 0x3ff000) >> 12);
> > - qv[DACK_SN_8822C - 1] = (s32)(temp & 0x3ff);
> > + iv[DACK_SN_8822C - 1] = sign_extend32((temp & 0x3ff000) >> 12, 9);
> > + qv[DACK_SN_8822C - 1] = sign_extend32(temp & 0x3ff, 9);
>
> FIELD_GET_SIGNED()
>
> Please use real hardware to verify the values.
>
Consider the change of sign_extend32() again. The value is not the same
as before. So, if people run this intermediate patch, the result will be
wrong. Please think how to rearrange your changes.
next prev parent reply other threads:[~2026-08-14 8:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-12 14:45 [PATCH 0/4] wifi: rtw88: rtw8822c: refactor DAC IQ calibration to s32 Arsenii Pashchenko
2026-08-12 14:45 ` [PATCH 1/4] wifi: rtw88: rtw8822c: convert DAC IQ buffers and signatures " Arsenii Pashchenko
2026-08-14 7:42 ` Ping-Ke Shih
2026-08-12 14:45 ` [PATCH 2/4] wifi: rtw88: rtw8822c: use sign_extend32 for DAC IQ validation Arsenii Pashchenko
2026-08-14 7:49 ` Ping-Ke Shih
2026-08-14 8:03 ` Ping-Ke Shih [this message]
2026-08-12 14:45 ` [PATCH 3/4] wifi: rtw88: rtw8822c: switch to the kernel's sort() library Arsenii Pashchenko
2026-08-14 7:57 ` Ping-Ke Shih
2026-08-12 14:45 ` [PATCH 4/4] wifi: rtw88: rtw8822c: simplify amplitude search and offset via s32 Arsenii Pashchenko
2026-08-14 8:10 ` Ping-Ke Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c469acfcbf29407ebf04ad921339aeea@realtek.com \
--to=pkshih@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=ulijg308@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox