Linux wireless drivers development
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211_hwsim: add frame transmission support over virtio
Date: Thu, 05 Mar 2020 15:03:57 +0100	[thread overview]
Message-ID: <c5319f6630be431c8680051fd4c33d59524683a2.camel@sipsolutions.net> (raw)
In-Reply-To: <2F7ADB4C-8C2C-4DEC-80AF-9E2D6B55CA88@holtmann.org>

Hi Marcel,
> 
> > This allows communication with external entities.
> > 
> > It also required fixing up the netlink policy, since NLA_UNSPEC
> > attributes are no longer accepted.
> > 
> > Signed-off-by: Erel Geron <erelx.geron@intel.com>
> > [port to backports, inline the ID, use 29 as the ID as requested,
> > drop != NULL checks, reduce ifdefs]
> > Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> 
> since the module now can auto-load, don’t you want to change radios = 2 to radio = 0?

Hmm. I didn't really want to change the behaviour there, and the auto-
loading is *highly* unlikely, you need to specifically set up a vhost-
user wmediumd (which I'm in the process of publishing).

And even then, you still need to have the radios, they just don't
communicate directly with each other but will go into wmediumd over the
virtio when you actually have virtio.

I'm not principally opposed to changing the default, but I'm not
convinced it'd be related to this patch in any way.

johannes


  reply	other threads:[~2020-03-05 14:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-05 13:32 [PATCH] mac80211_hwsim: add frame transmission support over virtio Johannes Berg
2020-03-05 13:59 ` Marcel Holtmann
2020-03-05 14:03   ` Johannes Berg [this message]
2020-03-05 14:09     ` Marcel Holtmann
2020-03-05 14:14       ` Johannes Berg
2020-03-05 14:18         ` Marcel Holtmann
2020-03-05 14:20           ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c5319f6630be431c8680051fd4c33d59524683a2.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=marcel@holtmann.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox