From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59606C433EF for ; Wed, 20 Apr 2022 05:20:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346941AbiDTFXl (ORCPT ); Wed, 20 Apr 2022 01:23:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57386 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241585AbiDTFXk (ORCPT ); Wed, 20 Apr 2022 01:23:40 -0400 Received: from nbd.name (nbd.name [IPv6:2a01:4f8:221:3d45::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A3A8B3587B for ; Tue, 19 Apr 2022 22:20:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nbd.name; s=20160729; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe :List-Post:List-Owner:List-Archive; bh=YAZC9y8BBhsm62CdLgduktz90VpmUPVlcKmGJkLc64w=; b=lA91Tk/4hnua5jf4aEIAWRR1sV WIKl9OGKQoW/fH/6ev9Qqb5GdhIJfDlbokw0y2slAZs+912GNSY4xQo5i0jMUZ6yriao4VVjeVRcU EDZoEJ5JRE2U/IIspZKQSzr68VZANu47JkOMKteLVHw3KomerHBP9OqnnpEQphZkz4xo=; Received: from p200300daa70ef200009e86881025829d.dip0.t-ipconnect.de ([2003:da:a70e:f200:9e:8688:1025:829d] helo=nf.local) by ds12 with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1nh2ll-00024n-85; Wed, 20 Apr 2022 07:20:49 +0200 Message-ID: Date: Wed, 20 Apr 2022 07:20:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Content-Language: en-US To: Bo Jiao Cc: linux-wireless , Ryder Lee , Sujuan Chen , Shayne Chen , Evelyn Tsai , linux-mediatek References: <20220420040346.8378-1-bo.jiao@mediatek.com> From: Felix Fietkau Subject: Re: [PATCH] mt76: mt7915: report qos_ctl without ACK policy In-Reply-To: <20220420040346.8378-1-bo.jiao@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 20.04.22 06:03, Bo Jiao wrote: > From: Bo Jiao > > there is no need to report to the mac80211 layer the ACK policy which may > cause rx out-of-order issue, because the hardware rmac module already handle it > > Signed-off-by: Bo Jiao > --- > drivers/net/wireless/mediatek/mt76/mt7915/mac.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/mac.c b/drivers/net/wireless/mediatek/mt76/mt7915/mac.c > index b47aea6..5080280 100644 > --- a/drivers/net/wireless/mediatek/mt76/mt7915/mac.c > +++ b/drivers/net/wireless/mediatek/mt76/mt7915/mac.c > @@ -675,6 +675,11 @@ mt7915_mac_fill_rx(struct mt7915_dev *dev, struct sk_buff *skb) > > fc = cpu_to_le16(FIELD_GET(MT_RXD6_FRAME_CONTROL, v0)); > qos_ctl = FIELD_GET(MT_RXD8_QOS_CTL, v2); > + /* > + * there is no need to report the ACK policy to the > + * mac80211 layer, because hw has already processed it. > + */ > + qos_ctl &= ~IEEE80211_QOS_CTL_ACK_POLICY_MASK; I don't understand this change at all. First of all, the qos_ctl field isn't really reported to the mac80211 layer, it's used in mt76 internally. The rx reorder code uses it to detect no-ack policy in order to avoid reordering for it. Since you're masking out the ack policy, the value will be IEEE80211_QOS_CTL_ACK_POLICY_NORMAL, which ends up forcibly enabling rx reordering, even when the policy indicates no-ack. How does this help, and what part does the rmac module already handle? - Felix