From: Rakesh Pillai <pillair@codeaurora.org>
To: Ben Greear <greearb@candelatech.com>
Cc: ath10k <ath10k@lists.infradead.org>, linux-wireless@vger.kernel.org
Subject: Re: Regression with commit "ath10k: fill the channel survey results for WCN3990 correctly"
Date: Wed, 21 Aug 2019 14:12:27 -0700 [thread overview]
Message-ID: <c77c271a3d77d990b8de67cdbd8ea8c7@codeaurora.org> (raw)
In-Reply-To: <5D5DB246.7040402@candelatech.com>
Hi Ben,
Can you please check https://patchwork.kernel.org/patch/10844513/ ?
This change fixes the below mentioned regression. A different structure
is made for tlv specific event handling.
Thanks,
Rakesh Pillai.
On 2019-08-21 14:06, Ben Greear wrote:
> On 08/21/2019 01:56 PM, Ben Greear wrote:
>> Hello,
>>
>> I just noticed in 5.2.7+ kernel than this commit below appears to
>> break WMI
>> message for my 10.1 firmware, and based on code inspection, 10.2 will
>> be broken
>> as well.
>>
>> 10.1 struct ends with cycle_count, and 10.2 ends with one 32-bit
>> number
>> after that, but which is not chan_tx_pwr_range.
>>
>> I guess you need to create your own wmi msg for the WCN3990.
>>
>> The change to 10.4 chan_info event is also wrong for my relatively
>> new version of 10.4 code, so likely breaks firmware in use. last
>> member
>> in that struct in my 10.4 fw src is 'A_UINT32
>> rx_11b_mode_data_duration;'
>
> Sorry, I mis-read this 10.4 part of the patch, it was not changing the
> wmi event
> itself, so probably that part is fine.
>
> Thanks,
> Ben
>
>>
>>
>> commit 13104929d2ec32aec0552007d55b9e15bc07176b
>> Author: Rakesh Pillai <pillair@codeaurora.org>
>> Date: Wed Oct 17 16:50:03 2018 +0530
>>
>> ath10k: fill the channel survey results for WCN3990 correctly
>>
>>
>>
>> diff --git a/drivers/net/wireless/ath/ath10k/wmi.h
>> b/drivers/net/wireless/ath/ath10k/wmi.h
>> index 4971d61..58e33ab 100644
>> --- a/drivers/net/wireless/ath/ath10k/wmi.h
>> +++ b/drivers/net/wireless/ath/ath10k/wmi.h
>> @@ -6442,6 +6442,14 @@ struct wmi_chan_info_event {
>> __le32 noise_floor;
>> __le32 rx_clear_count;
>> __le32 cycle_count;
>> + __le32 chan_tx_pwr_range;
>> + __le32 chan_tx_pwr_tp;
>> + __le32 rx_frame_count;
>> + __le32 my_bss_rx_cycle_count;
>> + __le32 rx_11b_mode_data_duration;
>> + __le32 tx_frame_cnt;
>> + __le32 mac_clk_mhz;
>> +
>> } __packed;
>>
>>
>>
>> Thanks,
>> Ben
>>
next prev parent reply other threads:[~2019-08-21 21:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 20:56 Regression with commit "ath10k: fill the channel survey results for WCN3990 correctly" Ben Greear
2019-08-21 21:06 ` Ben Greear
2019-08-21 21:12 ` Rakesh Pillai [this message]
2019-08-21 21:15 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c77c271a3d77d990b8de67cdbd8ea8c7@codeaurora.org \
--to=pillair@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).