Linux wireless drivers development
 help / color / mirror / Atom feed
From: "Ron Rindjunsky" <rindjon@googlemail.com>
To: "Johannes Berg" <johannes@sipsolutions.net>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
	flamingice@sourmilk.net, tomas.winkler@intel.com,
	yi.zhu@intel.com
Subject: Re: [RFC PATCH 09/12 v2] iwlwifi: A-MPDU Tx conform API to mac80211
Date: Sun, 20 Jan 2008 17:35:09 +0200	[thread overview]
Message-ID: <c85cb4470801200735v6cdc4642k7b500b6202e9b346@mail.gmail.com> (raw)
In-Reply-To: <1200616570.5716.8.camel@johannes.berg>

> >  int iwl4965_mac_ampdu_action(struct ieee80211_hw *hw,
> >                            enum ieee80211_ampdu_mlme_action action,
> > -                          const u8 *addr, u16 tid, u16 ssn)
> > +                          u8 *addr, u16 tid, u16 *ssn)
> >  {
> >       struct iwl4965_priv *priv = hw->priv;
> >       int sta_id;
> > @@ -4733,12 +4733,18 @@ int iwl4965_mac_ampdu_action(struct ieee80211_hw *hw,
> >       switch (action) {
> >       case IEEE80211_AMPDU_RX_START:
> >               IWL_DEBUG_HT("start Rx\n");
> > -             iwl4965_sta_modify_add_ba_tid(priv, sta_id, tid, ssn);
> > +             iwl4965_sta_modify_add_ba_tid(priv, sta_id, tid, *ssn);
> >               break;
> >       case IEEE80211_AMPDU_RX_STOP:
> >               IWL_DEBUG_HT("stop Rx\n");
> >               iwl4965_sta_modify_del_ba_tid(priv, sta_id, tid);
> >               break;
>
>
> >  extern int iwl4965_mac_ampdu_action(struct ieee80211_hw *hw,
> >                                   enum ieee80211_ampdu_mlme_action action,
> > -                                 const u8 *addr, u16 tid, u16 ssn);
> > +                                 u8 *addr, u16 tid, u16 *ssn);
> >  #ifdef CONFIG_IWL4965_HT_AGG
>
> These changes need to be in patch 1 so that has a chance of compiling.
>

ok. I usually prefer not to mix mac80211 and iwlwifi changes on the
same patch, this is why i didn't put them in patch #1, but as this
code is already inside the tree i'll put them together.

> johannes
>
>

  reply	other threads:[~2008-01-20 15:35 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-16 18:40 [RFC PATCH 0/12 v2] mac80211/iwlwifi: A-MPDU Tx support Ron Rindjunsky
2008-01-16 18:40 ` [RFC PATCH 01/12 v2] mac80211: A-MPDU Tx add session's and low level driver's API Ron Rindjunsky
2008-01-16 18:40 ` [RFC PATCH 02/12 v2] mac80211: A-MPDU Tx add MLME structures Ron Rindjunsky
2008-01-16 18:40 ` [RFC PATCH 03/12 v2] mac80211: A-MPDU Tx adding basic functionality Ron Rindjunsky
2008-01-18  0:49   ` Johannes Berg
2008-01-20 15:36     ` Ron Rindjunsky
2008-01-16 18:40 ` [RFC PATCH 04/12 v2] mac80211: A-MPDU Tx MLME data initialization Ron Rindjunsky
2008-01-16 18:40 ` [RFC PATCH 05/12 v2] mac80211: A-MPDU add debugfs support Ron Rindjunsky
2008-01-16 18:40 ` [RFC PATCH 06/12 v2] mac80211: A-MPDU Tx adding qdisc support Ron Rindjunsky
2008-01-16 18:40 ` [RFC PATCH 07/12 v2] mac80211: A-MPDU Tx change tx_status to support Block Ack data Ron Rindjunsky
2008-01-16 18:40 ` [RFC PATCH 08/12 v2] mac80211: A-MPDU Tx add delBA from recipient support Ron Rindjunsky
2008-01-16 18:40 ` [RFC PATCH 09/12 v2] iwlwifi: A-MPDU Tx conform API to mac80211 Ron Rindjunsky
2008-01-18  0:36   ` Johannes Berg
2008-01-20 15:35     ` Ron Rindjunsky [this message]
2008-01-16 18:40 ` [RFC PATCH 10/12 v2] iwlwifi: A-MPDU Tx conform flows " Ron Rindjunsky
2008-01-16 18:40 ` [RFC PATCH 11/12 v2] iwlwifi: A-MPDU Tx conform block Ack rate scaling " Ron Rindjunsky
2008-01-16 18:41 ` [RFC PATCH 12/12 v2] iwlwifi: A-MPDU Tx activation by load measures Ron Rindjunsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c85cb4470801200735v6cdc4642k7b500b6202e9b346@mail.gmail.com \
    --to=rindjon@googlemail.com \
    --cc=flamingice@sourmilk.net \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=tomas.winkler@intel.com \
    --cc=yi.zhu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox