Re: [RFC PATCH v2] wifi: cfg80211: fix cqm_config access race

[Max Schulze <max.schulze@online.de>]

Thanks again. I have to back-port it to 6.1.45 manually and will do testing.

The buildscript reports 2 things,


a)


Am 15.08.23 um 13:42 schrieb Johannes Berg:

> diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h
> index d6fa7c8767ad..c0250c81973e 100644
> --- a/include/net/cfg80211.h
> +++ b/include/net/cfg80211.h
> @@ -6014,7 +6014,8 @@ struct wireless_dev {
>  	} wext;
>  #endif
>  
> -	struct cfg80211_cqm_config *cqm_config;
> +	struct wiphy_work cqm_rssi_work;
> +	struct cfg80211_cqm_config __rcu *cqm_config;

would *cqm_rssi_work be ok?


and b)


/root/linux-rpi/net/wireless/core.c: In function ‘_cfg80211_unregister_wdev’:
/root/linux-rpi/net/wireless/core.c:1167:9: error: implicit declaration of function ‘wiphy_work_cancel’ [-Werror=implicit-function-declaration]
 1167 |         wiphy_work_cancel(wdev->wiphy, &wdev->cqm_rssi_work);
      |         ^~~~~~~~~~~~~~~~~
/root/linux-rpi/net/wireless/core.c: In function ‘cfg80211_init_wdev’:
/root/linux-rpi/net/wireless/core.c:1319:2: error: implicit declaration of function ‘wiphy_work_init’; did you mean ‘wiphy_sysfs_init’? [-Werror=implicit-function-declaration]
 1319 |  wiphy_work_init(&wdev->cqm_rssi_work, cfg80211_cqm_rssi_notify_work);
      |  ^~~~~~~~~~~~~~~
      |  wiphy_sysfs_init


Is that something to worry about? (Building with warnings as error, I just disabled that for now)