Re: [PATCHv8 0/6] cfg80211/mac80211: Add support for TID specific configuration

[Johannes Berg <johannes@sipsolutions.net>]

On Fri, 2019-11-08 at 16:01 +0000, Sergey Matyukevich wrote:

> > I think we still need NL80211_TID_CONFIG_ATTR_OVERRIDE in some way
> > (maybe only as a flag attribute), since you could have
> > 
> >  * change all stations (some subset of TIDs) *including* already
> >    configured stations
> >  * or *excluding* already configured stations
> 
> Hmmm... Logic is straightforwad without this flag:
> - settings are applied to bitmasked TIDs of a single peer if address is specifed
> - settings are applied to bitmasked TIDs of all the peers if no address is specified

Sure, this is obvious, but what exactly does "all the peers" mean?

Say I do

set_tid_config(tids=0x1, peer=02:11:22:33:44:55, noack=yes)
set_tid_config(tids=0x1, peer=NULL, noack=no)

Does that reset peer 02:11:22:33:44:55, or not? This is not documented
right now, and one could argue both ways - the override for that
particular peer should stick, or should be removed. Which one is it?

> It looks like you want to infer too much from a single flag. Why keep this logic in
> cfg80211/mac80211/driver ?

I just want to disambiguate what "all the peers" means. Not sure what
you mean by keeping the logic?

johannes